You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2017/01/10 07:34:45 UTC

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review161040
-----------------------------------------------------------


Ship it!




Ship It!

- Guangya Liu


On \u5341\u4e8c\u6708 9, 2016, 9:38 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated \u5341\u4e8c\u6708 9, 2016, 9:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Guangya Liu <gy...@gmail.com>.

> On \u4e00\u6708 10, 2017, 7:34 a.m., Guangya Liu wrote:
> > Ship It!

I have committed this already, but seems do not have permission to close this review, will close this when got permission.

commit 653fe55b3f2e6cd76567945dbbec4a84c03f13c2
Author: Jay Guo <gu...@gmail.com>
Date:   Tue Jan 10 15:32:05 2017 +0800

    Fixed indentation of a function argument in master.cpp.

    Fixed indentation of a function argument in master.cpp.

    Review: https://reviews.apache.org/r/54365/


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review161040
-----------------------------------------------------------


On \u5341\u4e8c\u6708 9, 2016, 9:38 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated \u5341\u4e8c\u6708 9, 2016, 9:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>