You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/07/30 16:59:58 UTC

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/959

    [FLINK-2409] [webserver] Replaces ActorRefs with ActorGateways in the web servers

    Replaces the `ActorRefs` used in the `WebInfoServer`, its servlets and the `WebRuntimeMonitor` with `ActorGateways`. This provides automatic message decoration. E.g. `Cancel` messages sent from the web interface are now correctly wrapped in a `LeaderSessionMessage` and, thus, no longer make the `JobManager` stop upon receiving the undecorated message.
    
    Furthermore, this PR adds support for the new web interface with YARN.
    
    The `FlinkMiniCluster` and its subclasses store now a reference to a possibly started `WebMonitor` which allows the cluster to properly shut it down, when the cluster is stopped.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixWebInterface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/959.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #959
    
----
commit 4c26f1af95be300ffb7ed8db408cf3d5f395d064
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-07-29T16:03:52Z

    [FLINK-2409] [webserver] Replaces ActorRefs with ActorGateways in the web server to automatically decorate messages with a leader session ID.
    
    Refactored MiniCluster to also store a reference to the web server to stop it. Adds support for the new web interface for yarn
    
    Fix web server start condition

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/959


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/959#issuecomment-127176955
  
    Go ahead :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/959#issuecomment-126698555
  
    Travis failed only in one build where the `YARNSessionFIFOITCase` did not start. I suspect that it's due to the instability of the `YARNSessionFIFOITCase` test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/959#issuecomment-127176750
  
    If there are no objections, then I would like to merge this PR in the evening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2409] [webserver] Replaces ActorRefs wi...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/959#issuecomment-127048697
  
    Looks good.
    
    +1 to merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---