You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org> on 2007/01/09 00:44:27 UTC
[jira] Created: (ADFFACES-348) -tr-inhibit: all inhibits all after
include styles in skin css files
-tr-inhibit: all inhibits all after include styles in skin css files
--------------------------------------------------------------------
Key: ADFFACES-348
URL: https://issues.apache.org/jira/browse/ADFFACES-348
Project: MyFaces ADF-Faces
Issue Type: Bug
Reporter: Jeanne Waldman
-tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
Example:
.portlet-form-input-field {
/* Bug in Trinidad: */
-tr-inhibit: all;
padding: 8px;
-tr-rule-ref: selector(".AFLightAccentBackground::alias");
}
.PortletHeaderLink {
/* works fine */
-tr-inhibit: text-decoration;
color: pink;
}
generates:
.PortletHeaderLink,.xaz {color:pink}
.portlet-form-input-field,.xbw {padding:8px}
.PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
.portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
The same thing works in the xss format. We should do the same thing as what is done in xss.
<style selector=".portlet-form-input-field" resetProperties="true">
<property name="padding">4px</property>
<includeStyle name="AFLightAccentBackground"/>
</style>
<style selector=".PortletHeaderLink" >
<property name="text-decoration"/>
<property name="color">blue</property>
</style>
generates:
.PortletHeaderLink,.xaz {color:blue}
.portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ADFFACES-348) -tr-inhibit: all inhibits all after
include styles in skin css files
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman resolved ADFFACES-348.
-------------------------------------
Resolution: Fixed
http://svn.apache.org/viewvc?view=rev&rev=494539
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-348) -tr-inhibit: all inhibits all after
include styles in skin css files
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-348:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.0-incubating-core
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
> Fix For: 1.0.0-incubating-core
>
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-348) -tr-inhibit: all inhibits all
after include styles in skin css files
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463177 ]
Jeanne Waldman commented on ADFFACES-348:
-----------------------------------------
Note: There is a 'bug' in the bug report.
There should be only one colon for :alias:
Instead of:
-tr-rule-ref: selector(".AFLightAccentBackground::alias");
Use
-tr-rule-ref: selector(".AFLightAccentBackground:alias");
The bug still reproduces.
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Jeanne Waldman
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-348) -tr-inhibit: all inhibits all
after include styles in skin css files
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463184 ]
Simon Lessard commented on ADFFACES-348:
----------------------------------------
I disagree on this and I actually made it that way willingly. A command to inhibit all should do just that, inhibit everything from parents and includes imho.
If we want skinning to be consistent with CSS philosophy, then it should be that way as CSS does not take the order in which the style properties appear into account.
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Jeanne Waldman
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-348) -tr-inhibit: all inhibits all
after include styles in skin css files
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463178 ]
Jeanne Waldman commented on ADFFACES-348:
-----------------------------------------
The following scenario also doesn't work, so be sure to test this as well
<style selector=".portlet-form-input-field" resetProperties="true">
<property name="padding">4px</property>
<property name="background-color"/>
<includeStyle name="AFLightAccentBackground"/>
</style>
This inhibits the background-color, so you will see no background-color in the generated css.
The same thing, written in css, does not inhibit the background-color, and it should.
.portlet-form-input-field {
/* Bug in Trinidad: */
-tr-inhibit: all;
padding: 8px;
-tr-rule-ref: selector(".AFLightAccentBackground:alias");
-tr-inhibit: background-color;
}
Again the code is slightly different for css vs xss, when it should be the same.
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Jeanne Waldman
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-348) -tr-inhibit: all inhibits all
after include styles in skin css files
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463290 ]
Simon Lessard commented on ADFFACES-348:
----------------------------------------
I thought about this over the night and I changed my mind. It's true that current sematic is incorrect to inhibit locally imported properties.
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Jeanne Waldman
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-348) -tr-inhibit: all inhibits all after
include styles in skin css files
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman reassigned ADFFACES-348:
---------------------------------------
Assignee: Jeanne Waldman
> -tr-inhibit: all inhibits all after include styles in skin css files
> --------------------------------------------------------------------
>
> Key: ADFFACES-348
> URL: https://issues.apache.org/jira/browse/ADFFACES-348
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> -tr-inhibit all clears out properties AFTER the include of another styleclass. This is wrong. It should inhibit all first.
> Example:
> .portlet-form-input-field {
> /* Bug in Trinidad: */
> -tr-inhibit: all;
> padding: 8px;
> -tr-rule-ref: selector(".AFLightAccentBackground::alias");
>
> }
> .PortletHeaderLink {
> /* works fine */
> -tr-inhibit: text-decoration;
> color: pink;
> }
> generates:
> .PortletHeaderLink,.xaz {color:pink}
> .portlet-form-input-field,.xbw {padding:8px}
> .PortletHeaderLink/.PortletSugHeaderLink works fine. The problem is .portlet-form-input-field. It should generate
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:8px}
> The same thing works in the xss format. We should do the same thing as what is done in xss.
> <style selector=".portlet-form-input-field" resetProperties="true">
> <property name="padding">4px</property>
> <includeStyle name="AFLightAccentBackground"/>
> </style>
> <style selector=".PortletHeaderLink" >
> <property name="text-decoration"/>
> <property name="color">blue</property>
> </style>
> generates:
> .PortletHeaderLink,.xaz {color:blue}
> .portlet-form-input-field,.xbw {background-color:#e9e8e8;padding:4px}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira