You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2015/05/22 13:57:41 UTC

Review Request 34593: HIVE-10702 COUNT(*) over windowing 'x preceding and y preceding' doesn't work properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34593/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

HIVE-10702 COUNT(*) over windowing 'x preceding and y preceding' doesn't work properly


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFRollingPartition.java e195c0a2815687ded15d186cfe6279fdbc212819 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java d7817d90dce7c851affdf35aff65ce3de259c866 
  ql/src/test/queries/clientpositive/windowing_windowspec2.q 3e8aa93494c0ad9119f475deca9edef74beb8a46 
  ql/src/test/results/clientpositive/windowing_windowspec2.q.out 0879344a2364532c53ffc697ea402d99701d3723 

Diff: https://reviews.apache.org/r/34593/diff/


Testing
-------

Test has been done here https://issues.apache.org/jira/browse/HIVE-10702

Seems one test failed for unrelated reason.


Thanks,

Aihua Xu


Re: Review Request 34593: HIVE-10702 COUNT(*) over windowing 'x preceding and y preceding' doesn't work properly

Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34593/
-----------------------------------------------------------

(Updated May 22, 2015, 11:57 a.m.)


Review request for hive.


Repository: hive-git


Description (updated)
-------

HIVE-10702 COUNT(*) over windowing 'x preceding and y preceding' doesn't work properly


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFRollingPartition.java e195c0a2815687ded15d186cfe6279fdbc212819 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java d7817d90dce7c851affdf35aff65ce3de259c866 
  ql/src/test/queries/clientpositive/windowing_windowspec2.q 3e8aa93494c0ad9119f475deca9edef74beb8a46 
  ql/src/test/results/clientpositive/windowing_windowspec2.q.out 0879344a2364532c53ffc697ea402d99701d3723 

Diff: https://reviews.apache.org/r/34593/diff/


Testing
-------

Test has been done here https://issues.apache.org/jira/browse/HIVE-10702

Seems one test failed for unrelated reason.


Thanks,

Aihua Xu