You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/02/04 00:10:21 UTC
Review Request 43160: Made `JSON::parse` disallow duplicate keys in
stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43160/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582
Repository: mesos
Description
-------
Since some JSON libraries disallow the presence of duplicate keys, we should restrict our JSON library to disallow them as well, to help mitigate issues that arise with other restrictive JSON libraries.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 87d018386ea59b16bf69b529426b6567727ed545
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 4ea610c3cd373f05843954763173b9bd51d8d5f5
Diff: https://reviews.apache.org/r/43160/diff/
Testing
-------
Added `TEST(JsonTest, DuplicateKeys)` test to `3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp` + `make check`
Thanks,
Michael Park
Re: Review Request 43160: Made `JSON::parse` disallow duplicate keys
in stout.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43160/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 11:12 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582
Repository: mesos
Description (updated)
-------
Made `JSON::parse` disallow duplicate keys in stout.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 87d018386ea59b16bf69b529426b6567727ed545
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 4ea610c3cd373f05843954763173b9bd51d8d5f5
Diff: https://reviews.apache.org/r/43160/diff/
Testing
-------
Added `TEST(JsonTest, DuplicateKeys)` test to `3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp` + `make check`
Thanks,
Michael Park