You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by agoodm <gi...@git.apache.org> on 2016/11/13 23:50:58 UTC

[GitHub] zeppelin pull request #1628: [HOTFIX][ZEPPELIN-1656] z.show in Python interp...

GitHub user agoodm opened a pull request:

    https://github.com/apache/zeppelin/pull/1628

    [HOTFIX][ZEPPELIN-1656] z.show in Python interpreter does not work

    ### What is this PR for?
    There have been reports of #1534 causing the python interpreter to always show an error because `z` is not being set. As it turns out this is a result of improperly handling the case when matplotlib isn't found when initializing the interpreter.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1656](https://issues.apache.org/jira/browse/ZEPPELIN-1656)
    
    ### How should this be tested?
    Run any simple python paragraph.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agoodm/zeppelin patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1628
    
----
commit 0a7a9d7b9b1bbb962fc511f21be74b3ca26a3339
Author: Alex Goodman <ag...@users.noreply.github.com>
Date:   2016-11-13T23:32:16Z

    Fix indent in bootstrap.py

commit 67f2ad5f3cb91d17d8a741983ce696a47aa355dc
Author: Alex Goodman <ag...@users.noreply.github.com>
Date:   2016-11-13T23:48:29Z

    python interpeter should work when matplotlib is not installed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1628: [HOTFIX][ZEPPELIN-1656] z.show in Python interpreter d...

Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:

    https://github.com/apache/zeppelin/pull/1628
  
    @bzz please test ASAP!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1628: [HOTFIX][ZEPPELIN-1656] z.show in Python interp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1628


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1628: [HOTFIX][ZEPPELIN-1656] z.show in Python interpreter d...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1628
  
    Tested with and without `matplotlib` - both cases work fine!
    
    Also
    
    ```
    %python
    
    a = 'a'
    print "{}".format(a)
    ```
    
    works as expected as well!
    
    \U0001f44d  thank you for prompt fix, looks awesome to me, will merge to master as hotfix asap, if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1628: [HOTFIX][ZEPPELIN-1656] z.show in Python interpreter d...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1628
  
    Will test right now and post back


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---