You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 05:30:48 UTC
[GitHub] [airflow] jpyen opened a new pull request #14186: Unique pod name
jpyen opened a new pull request #14186:
URL: https://github.com/apache/airflow/pull/14186
Related: #14167
Allow pod name override in KubernetesPodOperator if pod_template is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aviau edited a comment on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
aviau edited a comment on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-783801011
Maybe start with a better pull request title? `kubernetes_pod: fix using template + setting name`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpyen commented on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
jpyen commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-780060859
Hi this is a really important issue which will prohibit people from running multiple instances of a task like concurrent DAGs or backfills should they be using the KubernetesPodOperator with a template file.
Please merge this request, or provide guidance for a proper fix which I will be happy to implement.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aviau edited a comment on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
aviau edited a comment on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-783801011
Maybe start with a better pull request title? `KubernetesOperator: fix setting pod name while using template`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aviau commented on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
aviau commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-784567087
For me I can confirm that setting the pod name works when applying this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-784586101
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aviau commented on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
aviau commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-783801011
Maybe start with a better pull request title? `KubernetesOperator: fix setting pod name while using template`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14186: Allow pod name override in KubernetesPodOperator if pod_template is used
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-809756729
> @ashb @kaxil how do I check if this change is now in a provider package?
This was included in Kubernetes Provider 1.0.2: https://airflow.apache.org/docs/apache-airflow-providers-cncf-kubernetes/stable/commits.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] armandleopold commented on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
armandleopold commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-785249013
Can't wait to see it in the next release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #14186:
URL: https://github.com/apache/airflow/pull/14186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-777212209
[The Workflow run](https://github.com/apache/airflow/actions/runs/556887014) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #14186: Allow pod name override in KubernetesPodOperator if pod_template is used
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-809755410
@ashb @kaxil how do I check if this change is now in a provider package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aviau edited a comment on pull request #14186: Unique pod name
Posted by GitBox <gi...@apache.org>.
aviau edited a comment on pull request #14186:
URL: https://github.com/apache/airflow/pull/14186#issuecomment-783801011
Maybe start with a better pull request title? `KubernetesOperator: fix setting pod name while using template`
Also does this fix generate unique ids like we would expect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org