You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/26 20:17:23 UTC

[GitHub] MaxGekk commented on issue #23811: [WIP][SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType

MaxGekk commented on issue #23811: [WIP][SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType
URL: https://github.com/apache/spark/pull/23811#issuecomment-467596580
 
 
   > The `RowEncoder` also needs to create timestamp objects for timestamp columns, we should apply the config there too.
   > I'd like to see `df.collect()` and UDF test cases.
   
   Added such tests - UDF test contains collect as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org