You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2013/04/19 17:34:11 UTC
[18/19] git commit: [flex-falcon] - [FalconJX] resolved TODO
[FalconJX] resolved TODO
Removed comment, the 'important' implementation is in FlexJS, which has it's own 'emitIdentifier'. The JSGoog implementation can remain 'as is'.
Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/28fc6a51
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/28fc6a51
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/28fc6a51
Branch: refs/heads/develop
Commit: 28fc6a51261643b6b233e36cd23907904947b387
Parents: 35850f2
Author: Erik de Bruin <er...@ixsoftware.nl>
Authored: Fri Apr 19 17:28:04 2013 +0200
Committer: Erik de Bruin <er...@ixsoftware.nl>
Committed: Fri Apr 19 17:28:04 2013 +0200
----------------------------------------------------------------------
.../internal/codegen/js/goog/JSGoogEmitter.java | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/28fc6a51/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
index 613b81a..49d23c6 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
@@ -572,9 +572,6 @@ public class JSGoogEmitter extends JSEmitter implements IJSGoogEmitter
}
}
- // XXX (erikdebruin) I desperately needed a way to bypass the addition
- // of the 'self' prefix when running the tests... Or
- // I'd have to put the prefix in ~150 asserts!
boolean isRunningInTestMode = cnode != null
&& cnode.getQualifiedName().equalsIgnoreCase("FalconTest_A");
if (writeSelf && !isRunningInTestMode)