You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "naturzukunft (via GitHub)" <gi...@apache.org> on 2025/04/17 16:05:43 UTC

[PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

naturzukunft opened a new pull request, #324:
URL: https://github.com/apache/commons-rdf/pull/324

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   With this PR commons-rdf is using the newest version (Tue, Apr 15, 2025) of rdf4j.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2817243026

   > > > Hi @naturzukunft
   > > > Would you please look into fixing the Java 21 build? I'm not comfortable with changes until we get builds on Java LTS versions fixed.
   > > > TY!
   > > 
   > > 
   > > I think it needs a jena expert to upgrade to a newer jena version! commons-rdf is using jena 3.5.0 from Oct 30, 2017. There are dependencies to artifacts, that are not available in the current jena release. I think i'm not the right one to do this upgrade.
   > 
   > Hello @naturzukunft
   > 
   > Do you think upgrading Jena is _required_ to run this component on Java 21? That would be unusual.
   
   at the moment i have no idea what the cause of the error is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2827980282

   @naturzukunft 
   
   Deployment to https://repository.apache.org/content/repositories/snapshots/ is not automatic. I just pushed a snapshot build. You can deploy locally with `mvn clean install` (except for `commons-rdf-integration-tests` which seems to be misconfigured).
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2815388804

   > > Hi @naturzukunft
   > > Would you please look into fixing the Java 21 build? I'm not comfortable with changes until we get builds on Java LTS versions fixed.
   > > TY!
   > 
   > I think it needs a jena expert to upgrade to a newer jena version! commons-rdf is using jena 3.5.0 from Oct 30, 2017. There are dependencies to artifacts, that are not available in the current jena release. I think i'm not the right one to do this upgrade.
   
   Hello @naturzukunft 
   
   Do you think upgrading Jena is _required_ to run this component on Java 21? That would be unusual.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2827928115

   But my pipeline is downloading an old version ;-(
   
   Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-rdf-api/0.6.0-SNAPSHOT/commons-rdf-api-0.6.0-20250322.134200-21.pom
   
   ```xml
   <repository>
   	<id>apache.snapshots</id>
   	<name>Apache Snapshot Repository</name>
   	<url>https://repository.apache.org/snapshots</url>
   	<releases>
   		<enabled>false</enabled>
   	</releases>
   </repository>
   ```
   expected: https://repository.apache.org/content/groups/snapshots/org/apache/commons/commons-rdf-api/0.6.0-SNAPSHOT/commons-rdf-api-0.6.0-20250124.151445-20.jar
   
   i changed now the url to:
   
   ```xml
   <repository>
   	<id>apache.snapshots</id>
   	<name>Apache Snapshot Repository</name>
   	<url>https://repository.apache.org/content/groups/snapshots</url>
   	<releases>
   		<enabled>false</enabled>
   	</releases>
   </repository>
   ```
   
   also the newest version is not loaded.
   
   In [maven-metadata.xml](https://repository.apache.org/content/groups/snapshots/org/apache/commons/commons-rdf-api/0.6.0-SNAPSHOT/maven-metadata.xml) the latest version is `<lastUpdated>20250322134200</lastUpdated>`, what feels somehow wrong?
   
   Any idea ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2827384133

   > @garydgregory is there a snapshot repo, where this version is available ?
   
   Found it [here](https://commons.apache.org/proper/commons-rdf/userguide.html#Using_Commons_RDF_from_Maven). Was expecting it in [Downloads](https://commons.apache.org/proper/commons-rdf/download.html).
   
   The url is wrong, it has to be `https`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2817269671

   See: https://github.com/apache/commons-rdf/pull/327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2823406431

   Good Morning @garydgregory,
   rebase is done.
   br


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2815364531

   > Hi @naturzukunft
   > 
   > Would you please look into fixing the Java 21 build? I'm not comfortable with changes until we get builds on Java LTS versions fixed.
   > 
   > TY!
   
   I think it needs a jena expert to upgrade to a newer jena version! commons-rdf is using jena 3.5.0 from Oct 30, 2017.
   There are dependencies to artifacts, that are not available in the current jena release. I think i'm not the right one to do this upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2822528180

   Hi @naturzukunft 
   
   Please rebase on git master.
   
   TY!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2827317470

   @garydgregory is there a snapshot repo, where this version is available ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #324:
URL: https://github.com/apache/commons-rdf/pull/324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2813829234

   Hi @naturzukunft 
   
   Would you please look into fixing the Java 21 build? I'm not comfortable with changes until we get builds on Java LTS versions fixed.
   
   TY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] upgrade rdf4j to 5.1.3 (Tue, Apr 15, 2025) [commons-rdf]

Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #324:
URL: https://github.com/apache/commons-rdf/pull/324#issuecomment-2817263181

   The original `org.apache.commons.rdf.api.AbstractDatasetTest`:
   
   ```
       @Test
       public void testStreamDefaultGraphNameByPattern() throws Exception {
           // Explicitly select in only the default graph Optional.empty()
           final Optional<? extends Quad> aliceTopic = dataset.stream(Optional.empty(), null, null, null).findAny();
           assertTrue(aliceTopic.isPresent());
           // COMMONSRDF-55: should not be <urn:x-arq:defaultgraph> or similar
           assertNull(aliceTopic.get().getGraphName().orElse(null));
           assertFalse(aliceTopic.get().getGraphName().isPresent());
       }
   ```
   is running with jdk 17.
   
   if i change it to this, which I think tests the same thing only slightly better, then the test also fails with jdk 17:
   ```
       @Test
       public void testStreamDefaultGraphNameByPattern() throws Exception {
           dataset.stream(Optional.empty(), null, null, null).forEach(quad -> {
               // COMMONSRDF-55: should not be <urn:x-arq:defaultgraph> or similar
               assertNull(quad.getGraphName().orElse(null));
               assertFalse(quad.getGraphName().isPresent());
           });
       }
   ```
   
   So in my opinion the test is wrong. And the order of the stream changes with a newer jdk, so `findAny()`  delivers another quad.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org