You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/03 15:15:04 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #8819: [CI] Fix maven install failure caused by spotbugs check

BewareMyPower opened a new pull request #8819:
URL: https://github.com/apache/pulsar/pull/8819


   ### Motivation
   
   [#8784](https://github.com/apache/pulsar/pull/8784) introduced spotsbug plugin for pulsar-package-management module and its submodules. However, [#8744](https://github.com/apache/pulsar/pull/8744) cannot pass the spotsbug check but all CI passed because it's an earlier PR that didn't include the spotsbug commit.
   
   Therefore, all PRs that rebased to the latest commit fail with all the CI checks. This PR is to fix it.
   
   ### Modifications
   
   Remove the private `DLOutputStream#writeAsync` method that is never used.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8819: [CI] Fix maven install failure caused by spotbugs check

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8819:
URL: https://github.com/apache/pulsar/pull/8819#issuecomment-738075290


   By the way, for pulsar committers, I suggested that if a PR contains changes **that may affect the basic build workflow**, it should be reviewed carefully. After it's merged, the other PRs should be checked if they rebased to the latest commit. If not, we should remind authors to rebase to the latest commit.
   
   If I remember correctly, the similar problem happened not long ago. And there're a lot of spotbugs plugins to be added to each module. If PRs were not reviewed carefully, the problem would be endless.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #8819: [CI] Fix maven install failure caused by spotbugs check

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #8819:
URL: https://github.com/apache/pulsar/pull/8819


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org