You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/02 16:16:11 UTC
[GitHub] [airflow] ohadmata opened a new pull request #7008: fix
ssh_operator default value
ohadmata opened a new pull request #7008: fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008
[AIRFLOW-6402] https://issues.apache.org/jira/browse/AIRFLOW-6402
Fix for ssh operator default value.
Right now I am getting Nonetype Exception (1.10.7)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dstandish edited a comment on issue #7008: [AIRFLOW-6402]
fix ssh_operator default value
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-572948026
this operator raises exception if no command is provided:
https://github.com/apache/airflow/blob/49845787feda26681456a56bf3fa11d3a1cb5cdf/airflow/contrib/operators/ssh_operator.py#L108-L109
does it make sense to just pass empty string `super().__init__(command='')` when subclassing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7008: [AIRFLOW-6402] fix
ssh_operator default value
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-590323584
> this operator raises exception if no command is provided:
> https://github.com/apache/airflow/blob/49845787feda26681456a56bf3fa11d3a1cb5cdf/airflow/contrib/operators/ssh_operator.py#L108-L109
>
> does it make sense to just pass empty string `super().__init__(command='')` when subclassing?
>
> seems like it would make sense to make `command` not optional i.e. remove the default value of `None`
Yes, I don't see why someone would use SSHOperator without a "command".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7008: [AIRFLOW-6402] fix
ssh_operator default value
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-572749165
Can you also add a test for it so this can be avoided in future, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dstandish commented on issue #7008: [AIRFLOW-6402] fix
ssh_operator default value
Posted by GitBox <gi...@apache.org>.
dstandish commented on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-572948026
this operator raises exception if no command is provided:
https://github.com/apache/airflow/blob/49845787feda26681456a56bf3fa11d3a1cb5cdf/airflow/contrib/operators/ssh_operator.py#L108
does it make sense to just pass empty string `super().__init__(command='')` when subclassing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] commented on issue #7008: [AIRFLOW-6402] fix
ssh_operator default value
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-590258427
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #7008: [AIRFLOW-6402] fix
ssh_operator default value
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-572749165
Can you also add a test for it so this can be avoided in future, please?
Test for this operator are at: https://github.com/apache/airflow/blob/master/tests/contrib/operators/test_ssh_operator.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dstandish edited a comment on issue #7008: [AIRFLOW-6402]
fix ssh_operator default value
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-572948026
this operator raises exception if no command is provided:
https://github.com/apache/airflow/blob/49845787feda26681456a56bf3fa11d3a1cb5cdf/airflow/contrib/operators/ssh_operator.py#L108-L109
does it make sense to just pass empty string `super().__init__(command='')` when subclassing?
seems like it would make sense to make `command` not optional i.e. remove the default value of `None`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services