[GitHub] [airflow] jhtimmins commented on a change in pull request #11389: Use permission constants

[GitBox <gi...@apache.org>]

jhtimmins commented on a change in pull request #11389:
URL: https://github.com/apache/airflow/pull/11389#discussion_r506981092



##########
File path: airflow/www/security.py
##########
@@ -630,7 +630,7 @@ def sync_perm_for_dag(self, dag_id, access_control=None):
         :type dag_id: str
         :param access_control: a dict where each key is a rolename and
             each value is a set() of permission names (e.g.,
-            {'can_read'}
+            {permissions.ACTION_CAN_READ}

Review comment:
       This is actually the result of a bad search and replace. I wasn't trying make comment strings use the constants. Do you think they should though?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org