You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/06 04:11:15 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #833: fix: add v2beta3 register resources
tao12345666333 opened a new pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833
Signed-off-by: Jintao Zhang <zh...@gmail.com>
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#discussion_r779651470
##########
File path: pkg/kube/apisix/apis/config/v2beta3/register.go
##########
@@ -42,6 +42,16 @@ func addKnownTypes(scheme *runtime.Scheme) error {
scheme.AddKnownTypes(SchemeGroupVersion,
&ApisixRoute{},
&ApisixRouteList{},
+ &ApisixUpstream{},
+ &ApisixUpstreamList{},
+ &ApisixTls{},
+ &ApisixTlsList{},
+ &ApisixClusterConfig{},
+ &ApisixClusterConfigList{},
+ &ApisixConsumer{},
+ &ApisixConsumerList{},
+ &ApisixPluginConfig{},
+ &ApisixPluginConfigList{},
Review comment:
I haven't thought of how to fix the CI problem for the time being. In fact, I have already submitted the generated file 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#issuecomment-1006271179
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#833](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92afdd9) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/83648210fe194fa42f5582e8773969be0a01fa57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8364821) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 32.13% 32.09% -0.05%
==========================================
Files 70 71 +1
Lines 7726 7721 -5
==========================================
- Hits 2483 2478 -5
Misses 4968 4968
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.64% <0.00%> (-1.38%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.55% <0.00%> (-0.45%)` | :arrow_down: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8364821...92afdd9](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#discussion_r779350877
##########
File path: pkg/kube/apisix/apis/config/v2beta3/register.go
##########
@@ -42,6 +42,16 @@ func addKnownTypes(scheme *runtime.Scheme) error {
scheme.AddKnownTypes(SchemeGroupVersion,
&ApisixRoute{},
&ApisixRouteList{},
+ &ApisixUpstream{},
+ &ApisixUpstreamList{},
+ &ApisixTls{},
+ &ApisixTlsList{},
+ &ApisixClusterConfig{},
+ &ApisixClusterConfigList{},
+ &ApisixConsumer{},
+ &ApisixConsumerList{},
+ &ApisixPluginConfig{},
+ &ApisixPluginConfigList{},
Review comment:
No, I will modify how this file is maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] starsz commented on a change in pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#discussion_r779539327
##########
File path: pkg/kube/apisix/apis/config/v2beta3/register.go
##########
@@ -42,6 +42,16 @@ func addKnownTypes(scheme *runtime.Scheme) error {
scheme.AddKnownTypes(SchemeGroupVersion,
&ApisixRoute{},
&ApisixRouteList{},
+ &ApisixUpstream{},
+ &ApisixUpstreamList{},
+ &ApisixTls{},
+ &ApisixTlsList{},
+ &ApisixClusterConfig{},
+ &ApisixClusterConfigList{},
+ &ApisixConsumer{},
+ &ApisixConsumerList{},
+ &ApisixPluginConfig{},
+ &ApisixPluginConfigList{},
Review comment:
Got it. And need to fix CI 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#issuecomment-1006271179
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#833](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92afdd9) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/83648210fe194fa42f5582e8773969be0a01fa57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8364821) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 32.13% 32.08% -0.06%
==========================================
Files 70 70
Lines 7726 7720 -6
==========================================
- Hits 2483 2477 -6
Misses 4968 4968
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.64% <0.00%> (-1.38%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.55% <0.00%> (-0.45%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8364821...92afdd9](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] starsz commented on a change in pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#discussion_r779311139
##########
File path: pkg/kube/apisix/apis/config/v2beta3/register.go
##########
@@ -42,6 +42,16 @@ func addKnownTypes(scheme *runtime.Scheme) error {
scheme.AddKnownTypes(SchemeGroupVersion,
&ApisixRoute{},
&ApisixRouteList{},
+ &ApisixUpstream{},
+ &ApisixUpstreamList{},
+ &ApisixTls{},
+ &ApisixTlsList{},
+ &ApisixClusterConfig{},
+ &ApisixClusterConfigList{},
+ &ApisixConsumer{},
+ &ApisixConsumerList{},
+ &ApisixPluginConfig{},
+ &ApisixPluginConfigList{},
Review comment:
Can you add test case to cover this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #833: fix: add v2beta3 register resources
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #833:
URL: https://github.com/apache/apisix-ingress-controller/pull/833#issuecomment-1006271179
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#833](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d622f3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/83648210fe194fa42f5582e8773969be0a01fa57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8364821) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 32.13% 32.08% -0.06%
==========================================
Files 70 70
Lines 7726 7720 -6
==========================================
- Hits 2483 2477 -6
Misses 4968 4968
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.64% <0.00%> (-1.38%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.55% <0.00%> (-0.45%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8364821...0d622f3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/833?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org