You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/05/06 08:49:13 UTC

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3772: [SCB-2791]Http2 client keepAliveTimeout is not properly set

liubao68 opened a new pull request, #3772:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3772

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3772: [SCB-2791]Http2 client keepAliveTimeout is not properly set

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3772:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3772#issuecomment-1537096868

   ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3772](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0c25d2) into [master](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/fc7625143101298850de8cd0954b9096334ee93a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc76251) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head d0c25d2 differs from pull request most recent head b0457a7. Consider uploading reports for the commit b0457a7 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3772      +/-   ##
   ============================================
   - Coverage     44.10%   43.83%   -0.28%     
   + Complexity     6094     6068      -26     
   ============================================
     Files          1555     1555              
     Lines         38208    38209       +1     
     Branches       3508     3508              
   ============================================
   - Hits          16853    16749     -104     
   - Misses        20051    20157     +106     
   + Partials       1304     1303       -1     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dation/vertx/client/http/HttpClientOptionsSPI.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9jbGllbnQvaHR0cC9IdHRwQ2xpZW50T3B0aW9uc1NQSS5qYXZh) | `70.37% <100.00%> (+1.13%)` | :arrow_up: |
   
   ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3772/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3772: [SCB-2791]Http2 client keepAliveTimeout is not properly set

Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #3772:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org