You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/17 17:20:57 UTC
[GitHub] [spark] sfc-gh-dhuo opened a new pull request, #37557: [SPARK-40128] [SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_…
sfc-gh-dhuo opened a new pull request, #37557:
URL: https://github.com/apache/spark/pull/37557
…BYTE_ARRAY as a standalone encong column encoding.
java.lang.UnsupportedOperationException: Unsupported encoding: DELTA_LENGTH_BYTE_ARRAY
Added additional test case to ParquetIOSuite based on the associated
test file from https://github.com/apache/parquet-testing
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Add DELTA_LENGTH_BYTE_ARRAY as a recognized encoding in VectorizedColumnReader so that
vectorized reads succeed when there are columns using DELTA_LENGTH_BYTE_ARRAY as a standalone
encoding.
### Why are the changes needed?
Spark currently throws an exception for DELTA_LENGTH_BYTE_ARRAY columns when vectorized
reads are enabled and trying to read `delta_length_byte_array.parquet` from https://github.com/apache/parquet-testing:
java.lang.UnsupportedOperationException: Unsupported encoding: DELTA_LENGTH_BYTE_ARRAY
### Does this PR introduce _any_ user-facing change?
Yes - previously throw UNSUPPORTED exception. Now reads the encoding same as if vectorized reads are disabled.
### How was this patch tested?
Added test case to ParquetIOSuite; made sure it fails without the fix to VectorizedColumnReader and passes after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sadikovi commented on a diff in pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sadikovi commented on code in PR #37557:
URL: https://github.com/apache/spark/pull/37557#discussion_r948494706
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1307,6 +1307,16 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSparkSession
}
}
+ test("SPARK-40128 read DELTA_LENGTH_BYTE_ARRAY encoded strings") {
+ withAllParquetReaders {
+ checkAnswer(
+ // "fruit" column in this file is encoded using DELTA_LENGTH_BYTE_ARRAY.
+ // The file comes from https://github.com/apache/parquet-testing
+ readResourceParquetFile("test-data/delta_length_byte_array.parquet"),
Review Comment:
Is it possible to generate this file instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37557: [SPARK-40128] [SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_…
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37557:
URL: https://github.com/apache/spark/pull/37557#issuecomment-1218318057
I am wondering if your GitHub actions are enabled...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sfc-gh-dhuo commented on pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sfc-gh-dhuo commented on PR #37557:
URL: https://github.com/apache/spark/pull/37557#issuecomment-1218638796
Excellent, thanks for the quick turnaround!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sunchao commented on PR #37557:
URL: https://github.com/apache/spark/pull/37557#issuecomment-1218632886
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sfc-gh-dhuo commented on pull request #37557: [SPARK-40128] [SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_…
Posted by GitBox <gi...@apache.org>.
sfc-gh-dhuo commented on PR #37557:
URL: https://github.com/apache/spark/pull/37557#issuecomment-1218426428
@kazuyukitanimura Thanks for the reminder! I've enabled github actions now and verified at least "Build and test" and "Report test results" are enabled workflows; not sure if it takes some time for them to trigger though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sadikovi commented on a diff in pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sadikovi commented on code in PR #37557:
URL: https://github.com/apache/spark/pull/37557#discussion_r948519664
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1307,6 +1307,16 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSparkSession
}
}
+ test("SPARK-40128 read DELTA_LENGTH_BYTE_ARRAY encoded strings") {
+ withAllParquetReaders {
+ checkAnswer(
+ // "fruit" column in this file is encoded using DELTA_LENGTH_BYTE_ARRAY.
+ // The file comes from https://github.com/apache/parquet-testing
+ readResourceParquetFile("test-data/delta_length_byte_array.parquet"),
Review Comment:
It is fine, let's keep as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37557:
URL: https://github.com/apache/spark/pull/37557#issuecomment-1218951098
+1, late LGTM. Thank you @sfc-gh-dhuo @kazuyukitanimura @sunchao @sadikovi @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao closed pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sunchao closed pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
URL: https://github.com/apache/spark/pull/37557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37557: [SPARK-40128] [SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_…
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37557:
URL: https://github.com/apache/spark/pull/37557#issuecomment-1218513477
LGTM (non-binding) pending on CI. cc @sunchao @LuciferYang @sadikovi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sfc-gh-dhuo commented on a diff in pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sfc-gh-dhuo commented on code in PR #37557:
URL: https://github.com/apache/spark/pull/37557#discussion_r948523999
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1307,6 +1307,16 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSparkSession
}
}
+ test("SPARK-40128 read DELTA_LENGTH_BYTE_ARRAY encoded strings") {
+ withAllParquetReaders {
+ checkAnswer(
+ // "fruit" column in this file is encoded using DELTA_LENGTH_BYTE_ARRAY.
+ // The file comes from https://github.com/apache/parquet-testing
+ readResourceParquetFile("test-data/delta_length_byte_array.parquet"),
Review Comment:
Yeah, looks like there's unfortunately not much configurability for choosing encodings in typical writer libraries; I saw this discussion from a couple years ago on that topic for a similar question about wanting to target specific encodings: https://www.mail-archive.com/dev@parquet.apache.org/msg11826.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a diff in pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
sunchao commented on code in PR #37557:
URL: https://github.com/apache/spark/pull/37557#discussion_r948518733
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1307,6 +1307,16 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSparkSession
}
}
+ test("SPARK-40128 read DELTA_LENGTH_BYTE_ARRAY encoded strings") {
+ withAllParquetReaders {
+ checkAnswer(
+ // "fruit" column in this file is encoded using DELTA_LENGTH_BYTE_ARRAY.
+ // The file comes from https://github.com/apache/parquet-testing
+ readResourceParquetFile("test-data/delta_length_byte_array.parquet"),
Review Comment:
It looks a bit tricky to generate data using `DELTA_LENGTH_BYTE_ARRAY` since `parquet-mr` by default uses `DELTA_BYTE_ARRAY` for binary type. We can probably do this separately later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] parthchandra commented on a diff in pull request #37557: [SPARK-40128][SQL] Make the VectorizedColumnReader recognize DELTA_LENGTH_BYTE_ARRAY as a standalone column encoding
Posted by GitBox <gi...@apache.org>.
parthchandra commented on code in PR #37557:
URL: https://github.com/apache/spark/pull/37557#discussion_r948527571
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1307,6 +1307,16 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSparkSession
}
}
+ test("SPARK-40128 read DELTA_LENGTH_BYTE_ARRAY encoded strings") {
+ withAllParquetReaders {
+ checkAnswer(
+ // "fruit" column in this file is encoded using DELTA_LENGTH_BYTE_ARRAY.
+ // The file comes from https://github.com/apache/parquet-testing
+ readResourceParquetFile("test-data/delta_length_byte_array.parquet"),
Review Comment:
One of the reasons I didn't include this in the list is because I found no way of actually creating a file with a DELTA_LENGTH_BYTE_ARRAY encoding. So yeah, it's hard to do !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org