You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2023/01/23 18:17:45 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7737: [HUDI-5593] Move post-commit operations out of write transaction

nsivabalan commented on code in PR #7737:
URL: https://github.com/apache/hudi/pull/7737#discussion_r1084393849


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -244,6 +242,7 @@ public boolean commitStats(String instantTime, List<HoodieWriteStat> stats, Opti
     // We don't want to fail the commit if hoodie.fail.writes.on.inline.table.service.exception is false. We catch warn if false
     try {
       // do this outside of lock since compaction, clustering can be time taking and we don't need a lock for the entire execution period
+      postCommit(table, metadata, instantTime, extraMetadata, false);

Review Comment:
   there is much more to this. this is skipping locks for inline cleaning. I will take over from here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org