[GitHub] wvengen commented on issue #359: beforeload causing POST failure

[GitBox <gi...@apache.org>]

wvengen commented on issue #359: beforeload causing POST failure
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/359#issuecomment-444097219
 
 
   That's a good point - the callback basically loads the URL again, indeed POST data would not be present - I'm afraid even the method would get lost. This might also be an issue for the referer (depending on how that is derived).
   
   To fix this, I think the following would be needed:
   - include method and POST data in the event
   - pass these on to the callback (e.g. as extra parameters)
   
   When these arguments are missing, the `GET` method would be assumed.
   I hope this data is available in the relevant callbacks, it depends on platform support. If the method is available but POST data not, we might want to skip the callback for POST requests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org