[GitHub] [superset] hughhhh commented on a change in pull request #16095: feat: added google alert to DB Connection Form

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #16095:
URL: https://github.com/apache/superset/pull/16095#discussion_r683754027



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -1188,18 +1218,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
                   dbName={dbName}
                   dbModel={dbModel}
                 />
-                {connectionAlert && (
-                  <StyledAlertMargin>
-                    <Alert
-                      closable={false}
-                      css={(theme: SupersetTheme) => antDAlertStyles(theme)}
-                      type="info"
-                      showIcon
-                      message={t('IP Allowlist')}
-                      description={connectionAlert.ALLOWED_IPS}
-                    />
-                  </StyledAlertMargin>
-                )}
+                {connectionAlert && renderStepTwoAlert()}

Review comment:
       I wanted to refactor this to be driven by `superset_text.yml`.
   
   1. We'd update the superset_text schema to look like this:
   ```
   DB_CONNECTION_ALERT:
       catalog:  # gsheets specific
            message: <add message here>
            description: <add description hear>
      host:  # basic mixin specific
           message: <add message here>
           description: <add description hear>
   ```
   
   2. Based upon what is parameters come back in the `/available` endpoint and what the config has we'd render the alert accordingly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org