You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by David Blevins <da...@visi.com> on 2003/09/03 18:58:31 UTC

Re: Closing items 49-56,58-65 as duplicate -- PLEASE READ

On Tue, Sep 02, 2003 at 11:06:59PM -0700, Brian Behlendorf wrote:
> 
> If you want an opinion from someone to the side, it's seems quite
> preferable to have separate issues remain separate and open, even if they
> are all very related, until each is closed.  Doesn't strike me that
> closing all these issues as duplicates was a good idea.
> 
> 	Brian

I agree totally, but I don't think bug tracking is the real issue here.


There have been a few very critical emails on this incident.  I have compiled a list of the changes so that everyone may understand why they were grouped.  Please note the times.


TIME    NO   DESC
 5:45   49 - Misspelled a word
 6:03   50 - Added a parameter to a method
 7:17   51 - Changed a signature from public to private
 8:05   52 - Same change as 51, plus additional changes
 8:11   53 - Changed a signature from public to private (updates 52)
 9:45   54 - More complete patches to javax.mail
 9:48   55 - Added a toString method (3 lines of code)
 9:50   56 - Revision to a javax.mail class, added test case
10:08   58 - Revision to a javax.mail.internet class, added test case
10:10   59 - Revision to a javax.mail.internet class, added test case
10:12   60 - Revision to a javax.mail.internet class, added test case
10:15   61 - Revision to a javax.mail.internet class, added test case
10:19   62 - Revision to a javax.mail.internet class, added test case
10:23   63 - Revision to a javax.mail.internet class, added test case
10:27   64 - Revisions javax.mail.event package
10:32   65 - Revision to a javax.mail.internet class, added test case

16 total in a span of 5 hours, all to packages only Alex is working on.  

I am very happy to review changes and assist contributors, but I do not encourage people to send a steady stream of patches all day long because they are upset they don't have cvs privileges and are trying to make a point.

-David

Re: Closing items 49-56,58-65 as duplicate -- PLEASE READ

Posted by Dain Sundstrom <da...@coredevelopers.net>.
Give David a break.

You all seem to be forgetting that David is a volunteer also, and 
wasting his time and effort is just a bad a wasting anyone else's time. 
  Dealing with a bug in the tracker has a certain amount of overhead 
(even is a great one like Jira), so from David's perspective  (and 
mine) Alex simply went and create 16 times the work.  Now, don't get 
all melodramatic I'm not saying Alex should just send a huge patch once 
a week either.  He needs to use good judgment, as a huge patch can be 
near impossible to figure out.

So Alex, please think about the person on the receiving end of you 
patches next time.

-dain


On Wednesday, September 3, 2003, at 08:06 PM, Mark Mahieu wrote:

> David, I'm really having trouble understanding what you mean by that.  
> Now I'm sure there must be more to it, and I doubt (hope) you didn't 
> mean it to come across this way but it seems you've pretty much just 
> publicly characterised one of your most enthusiastic contributors as a 
> petulant brat simply because he used the bug-tracking system in a way 
> that didn't suit you.  If there have been guidelines prominently set 
> out about what is or is not acceptable practise then I apologise.  I 
> can't see them anywhere though, so I have to wonder whether I may fall 
> foul of the same kind of 'mistake' that Alex apparently just has if I 
> start contributing code.
>
> Regardless, this all seems to have been blown way out of proportion.  
> Personally, my feeling is that if the committers want contributors to 
> be useful to the project then they should at the very least publish 
> guidelines on how they wish JIRA etc to be used.  Then gently point 
> people at those guidelines the first time you deem them to have 
> offended.  As some of the committers love to tell people, this project 
> has a WIKI.  It even has a FAQ for developers!
>
> I really hope I've got the wrong end of the stick here, but as one of 
> the many people on the 'outside' of this project looking in and 
> wondering whether to get actively involved, the public mailing lists 
> aren't presenting the most attractive image.
>
> Regards,
>
> Mark
>
>

/*************************
  * Dain Sundstrom
  * Partner
  * Core Developers Network
  *************************/


Re: Closing items 49-56,58-65 as duplicate -- PLEASE READ

Posted by Mark Mahieu <ma...@twistedbanana.demon.co.uk>.
>I agree totally, but I don't think bug tracking is the real issue here.
>  
>
Indeed.

>There have been a few very critical emails on this incident.  I have compiled a list of the changes so that everyone may understand why they were grouped.  Please note the times.
>
><SNIPPED THE DETAILS>
>
>16 total in a span of 5 hours, all to packages only Alex is working on.  
>
In almost every company I've worked for professionally in the last few 
years, it has been pretty much *policy* to track issues individually 
exactly as Alex originally did, regardless of whether anyone else is 
working on that particular area of the system.  Whether or not it's 
actually *necessary* or even 'more work' for someone in each case is 
usually irrelevant; what matters is good general practise.

I'd be interested to know exactly which emails you consider to be 
critical by the way...

>I am very happy to review changes and assist contributors, but I do not encourage people to send a steady stream of patches all day long because they are upset they don't have cvs privileges and are trying to make a point.
>
>-David
>  
>
David, I'm really having trouble understanding what you mean by that.  
Now I'm sure there must be more to it, and I doubt (hope) you didn't 
mean it to come across this way but it seems you've pretty much just 
publicly characterised one of your most enthusiastic contributors as a 
petulant brat simply because he used the bug-tracking system in a way 
that didn't suit you.  If there have been guidelines prominently set out 
about what is or is not acceptable practise then I apologise.  I can't 
see them anywhere though, so I have to wonder whether I may fall foul of 
the same kind of 'mistake' that Alex apparently just has if I start 
contributing code.

Regardless, this all seems to have been blown way out of proportion.  
Personally, my feeling is that if the committers want contributors to be 
useful to the project then they should at the very least publish 
guidelines on how they wish JIRA etc to be used.  Then gently point 
people at those guidelines the first time you deem them to have 
offended.  As some of the committers love to tell people, this project 
has a WIKI.  It even has a FAQ for developers!

I really hope I've got the wrong end of the stick here, but as one of 
the many people on the 'outside' of this project looking in and 
wondering whether to get actively involved, the public mailing lists 
aren't presenting the most attractive image.

Regards,

Mark


Re: Closing items 49-56,58-65 as duplicate -- PLEASE READ

Posted by Brian Behlendorf <br...@collab.net>.
David, I still think there's nothing wrong with opening separate tickets
for genuinely separate issues, no matter how quickly you find them.  If
you think it's being done because "they are upset they don't have cvs
privileges" and it's annoying you, just give him CVS privileges and be
done with it.  Or review his patches and commit each of them, closing each
issue.  One of the points of using an issue tracker should be to get out
of the situation where only one person is working on a given piece of
code, and this is the right way to do that.

Volunteer motivation and energy are precious resources, and everything
that project leaders do should be around encouraging that rather than
deflecting it because it's annoying.

	Brian

On Wed, 3 Sep 2003, David Blevins wrote:
> There have been a few very critical emails on this incident.  I have
> compiled a list of the changes so that everyone may understand why they
> were grouped.  Please note the times.
>
>
> TIME    NO   DESC
>  5:45   49 - Misspelled a word
>  6:03   50 - Added a parameter to a method
>  7:17   51 - Changed a signature from public to private
>  8:05   52 - Same change as 51, plus additional changes
>  8:11   53 - Changed a signature from public to private (updates 52)
>  9:45   54 - More complete patches to javax.mail
>  9:48   55 - Added a toString method (3 lines of code)
>  9:50   56 - Revision to a javax.mail class, added test case
> 10:08   58 - Revision to a javax.mail.internet class, added test case
> 10:10   59 - Revision to a javax.mail.internet class, added test case
> 10:12   60 - Revision to a javax.mail.internet class, added test case
> 10:15   61 - Revision to a javax.mail.internet class, added test case
> 10:19   62 - Revision to a javax.mail.internet class, added test case
> 10:23   63 - Revision to a javax.mail.internet class, added test case
> 10:27   64 - Revisions javax.mail.event package
> 10:32   65 - Revision to a javax.mail.internet class, added test case
>
> 16 total in a span of 5 hours, all to packages only Alex is working on.
>
> I am very happy to review changes and assist contributors, but I do not
> encourage people to send a steady stream of patches all day long because
> they are upset they don't have cvs privileges and are trying to make a
> point.
>
> -David
>

Re: Closing items 49-56,58-65 as duplicate -- PLEASE READ

Posted by Alex Blewitt <Al...@ioshq.com>.
On Wednesday, Sep 3, 2003, at 17:58 Europe/London, David Blevins wrote:

> On Tue, Sep 02, 2003 at 11:06:59PM -0700, Brian Behlendorf wrote:
>>
>> If you want an opinion from someone to the side, it's seems quite
>> preferable to have separate issues remain separate and open, even if 
>> they
>> are all very related, until each is closed.  Doesn't strike me that
>> closing all these issues as duplicates was a good idea.
>>
>> 	Brian
>
> I agree totally, but I don't think bug tracking is the real issue here.

The bug tracking system is perfectly capable of handling many bugs, and 
indeed they may be related. This is why the bug-tracking system has 
dependency information.

> There have been a few very critical emails on this incident.  I have 
> compiled a list of the changes so that everyone may understand why 
> they were grouped.  Please note the times.

There have, from what I can see, been a similar number of e-mails both 
being critical for, and critical against.

> TIME    NO   DESC
>  5:45   49 - Misspelled a word
>  6:03   50 - Added a parameter to a method
>  7:17   51 - Changed a signature from public to private
>  8:05   52 - Same change as 51, plus additional changes
>  8:11   53 - Changed a signature from public to private (updates 52)

These were in response to Davanum Srinivas' mail that pointed out 
discrepancies between the JavaMail specification and were individual 
bugs in themselves. They should have been tracked separately, and were 
therefore filed as such.

>  9:45   54 - More complete patches to javax.mail
>  9:48   55 - Added a toString method (3 lines of code)
>  9:50   56 - Revision to a javax.mail class, added test case
> 10:08   58 - Revision to a javax.mail.internet class, added test case
> 10:10   59 - Revision to a javax.mail.internet class, added test case
> 10:12   60 - Revision to a javax.mail.internet class, added test case
> 10:15   61 - Revision to a javax.mail.internet class, added test case
> 10:19   62 - Revision to a javax.mail.internet class, added test case
> 10:23   63 - Revision to a javax.mail.internet class, added test case
> 10:27   64 - Revisions javax.mail.event package
> 10:32   65 - Revision to a javax.mail.internet class, added test case

These were changes to varying classes, and providing new test cases in 
all. They could have been factored into one patch (or a small number of 
them) as I have already agreed.

> 16 total in a span of 5 hours, all to packages only Alex is working on.

And it was I who filed the bugs, mostly due to work that I did over the 
weekend when not connected.

Time of filing bug != time of working on bug.

> I am very happy to review changes and assist contributors, but I do 
> not encourage people to send a steady stream of patches all day long 
> because they are upset they don't have cvs privileges and are trying 
> to make a point.

I was not, in fact, trying to make a point. I was trying to provide 
sufficient detail so that instead of dumping a whole lot of changes in 
a single splat, I categorised what I had done in each one so that it 
was possible for more fine-detail commits (and therefore, commit 
messages) could be applied to the repository in the way in which I am 
accustomed to doing. It was better to play safe than sorry, and err on 
the side of too many than too few. In that way, the committer could 
decide what the appropriate action was, and group them where necessary.

It is unfortunate that this was interpreted as a measure of upset; in 
fact, it was more upsetting to see the response rather than a cause for 
submitting many patches. It is clear that the JIRA bug tracking system 
is capable of handling many bugs with relationships between them, and 
whilst I acknowledged there were many bugs filed and that there could 
have been fewer, it was easily a situation that could have been 
clarified instead of vented in public. Indeed, I tried to do so but had 
no response.

I am all for learning about other reasons/opinions/thoughts on how to 
do things better. Next time I have a set of changes, I will file them 
as a single non-atomic large patch as required by over-worked 
committers.

As for commiter status; I think the point has already been made that a 
meritocracy is based on two key points; the ability to code, and the 
ability to fit in with development philosophy. I am of the opinion that 
my contributions to the JavaMail packages satisfy the first, and that 
the discussions in which I have partaken on this discussion list show 
that I am very much someone who is interested in new ideas and new ways 
of doing things. Unfortunately, this does not necessarily mean that I 
also fit in with how the project has been started, nor 'in' with the 
initial development team, which is why I am where I am at the moment.

Unfortunately, my personal voyage of this experience has gone form 
actively interested person, through mildly disinterested, to downright 
disheartend about my input into the project. I feel this is a great 
shame for both me personally and what I could have contributed to the 
group in the future.

Alex.