[jira] Commented: (SCM-19) resolve file status ambiguities

["Torbj?rn EIkli Sm?rgrav (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/SCM-19?page=comments#action_58422 ] 

Torbjørn EIkli Smørgrav commented on SCM-19:
--------------------------------------------

I realized that I was not very consistent between my patch and my comment above. 
To clearify:

Some of the status are related to the status of the file in the working tree versus the repository eg. added and removed.

Others are just a tag that the file is involved in a transaction with the repository eg. checkedin and checkout.

Some status eg. update, added and removed are used in both cases and I think it should be separated. 
Updated should In my opinion be a transaction tag.

T

> resolve file status ambiguities
> -------------------------------
>
>          Key: SCM-19
>          URL: http://jira.codehaus.org/browse/SCM-19
>      Project: Maven SCM
>         Type: Task

>   Components: maven-scm-api
>     Reporter: Brett Porter
>      Fix For: 1.0
>  Attachments: MNG-19-maven-scm-api.patch
>
>
> currently ScmFileStatus just reports whatever the provider gave back, but means different things in different SCM's.
> eg. "updated" in CVS is UPDATED or PATCHED, in SVN it is UPDATED or MERGED.
> "added" in CVS is UPDATED, in SVN it is ADDED.
> The API should hide this from the user, though perhaps be able to give the extended info if necessary.
> I suggest isXXX flags instead:
> isUpdated()
> isAdded() - just came from an update
> isMerged()
> isInConflict()
> isNew() - new locally
> etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira