You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2021/11/29 01:24:13 UTC

[impala] 02/04: IMPALA-10954: Make create, drop methods of kudu catalog service public

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 8082d85273702c4abda22c3a2771726221f61c2c
Author: Deepti Sehrawat <de...@cloudera.com>
AuthorDate: Tue Oct 26 17:34:11 2021 -0700

    IMPALA-10954: Make create, drop methods of kudu catalog service public
    
    External frontend needs access to some private methods of kudu catalog
    service. Hence, they are made public here to add support for CREATE and
    DROP tables for Kudu from external frontend.
    
    Change-Id: Ib60142424d8e758031de596831d98aed69d488ef
    Reviewed-on: http://gerrit.cloudera.org:8080/17981
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Aman Sinha <am...@cloudera.com>
    Reviewed-by: Aman Sinha <am...@cloudera.com>
---
 .../main/java/org/apache/impala/service/KuduCatalogOpExecutor.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java b/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
index 1c49f72..1ac8783 100644
--- a/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
+++ b/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
@@ -74,8 +74,9 @@ public class KuduCatalogOpExecutor {
    * Throws an exception if 'msTbl' represents an external table or if the table couldn't
    * be created in Kudu.
    */
-  static void createSynchronizedTable(org.apache.hadoop.hive.metastore.api.Table msTbl,
-      TCreateTableParams params) throws ImpalaRuntimeException {
+  public static void createSynchronizedTable(
+          org.apache.hadoop.hive.metastore.api.Table msTbl,
+          TCreateTableParams params) throws ImpalaRuntimeException {
     Preconditions.checkState(KuduTable.isSynchronizedTable(msTbl));
     Preconditions.checkState(
         msTbl.getParameters().get(KuduTable.KEY_TABLE_ID) == null);
@@ -263,7 +264,7 @@ public class KuduCatalogOpExecutor {
    * TableNotFoundException is thrown. If the table exists and could not be dropped,
    * an ImpalaRuntimeException is thrown.
    */
-  static void dropTable(org.apache.hadoop.hive.metastore.api.Table msTbl,
+  public static void dropTable(org.apache.hadoop.hive.metastore.api.Table msTbl,
       boolean ifExists) throws ImpalaRuntimeException, TableNotFoundException {
     Preconditions.checkState(KuduTable.isSynchronizedTable(msTbl));
     String tableName = msTbl.getParameters().get(KuduTable.KEY_TABLE_NAME);