[GitHub] [servicecomb-java-chassis] yhs0092 commented on a change in pull request #1524: [SCB-1716] Fix high cpu load when there are too many instances

[GitBox <gi...@apache.org>]

yhs0092 commented on a change in pull request #1524: [SCB-1716] Fix high cpu load when there are too many instances
URL: https://github.com/apache/servicecomb-java-chassis/pull/1524#discussion_r365635575
 
 

 ##########
 File path: foundations/foundation-config/src/main/resources/mapping.yaml
 ##########
 @@ -16,3 +16,6 @@
 ## ---------------------------------------------------------------------------
 
 SERVICECOMB_ENV: service_description.environment
+
+servicecomb.loadbalance.stats.timerIntervalInMillis:
+  - servicecomb.loadbalance.stats.timerIntervalInMilis
 
 Review comment:
   Hello, it's better to write a UT case to cover here.
   This configuration seems wrong. It means mapping `servicecomb.loadbalance.stats.timerIntervalInMillis` to `servicecomb.loadbalance.stats.timerIntervalInMilis`, while it doesn't take effect in the opposite direction. Since you get the config value from `servicecomb.loadbalance.stats.timerIntervalInMillis`, maybe here should be like below?
   ```yaml
   servicecomb.loadbalance.stats.timerIntervalInMilis:
     - servicecomb.loadbalance.stats.timerIntervalInMillis
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services