[GitHub] [druid] clintropolis commented on a change in pull request #10543: Avatica protobuf

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10543:
URL: https://github.com/apache/druid/pull/10543#discussion_r587315615



##########
File path: server/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java
##########
@@ -457,6 +470,95 @@ static String getAvaticaConnectionId(Map<String, Object> requestMap)
     return (String) connectionIdObj;
   }
 
+  static String getAvaticaProtobufConnectionId(Service.Request request)

Review comment:
       BTW, I guess the reason would be defensive for the most part, to more strongly type the check so that whenever we upgrade the library, stuff would fail at compile time instead of just fail in strange ways at run time if any of the requests ever change, however unlikely. 
   
   [Some of the unit tests for the json path are using the avatica types for json](https://github.com/apache/druid/blob/master/server/src/test/java/org/apache/druid/server/AsyncQueryForwardingServletTest.java#L462) to test this area already, so was just thinking since its used as a runtime depend now we could use the expected types for non tests too. But yeah, its definitely not necessary and doesn't provide a lot of gain, nor do I think we should do it in this PR or anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org