You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/02/19 18:14:19 UTC
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12524
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
---
M be/src/runtime/runtime-state.cc
M tests/webserver/test_web_pages.py
2 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12524/1
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 20:14:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12524
to look at the new patch set (#4).
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
This change also pads query IDs with zeros when printing them in the
backend.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
---
M be/src/runtime/runtime-state.cc
M be/src/util/debug-util.cc
M tests/webserver/test_web_pages.py
3 files changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12524/4
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12524
to look at the new patch set (#6).
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
This change also pads query IDs with zeros when printing them in the
backend.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
---
M be/src/runtime/runtime-state.cc
M be/src/util/debug-util.cc
M tests/webserver/test_web_pages.py
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12524/6
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12524/2/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/2/tests/webserver/test_web_pages.py@129
PS2, Line 129: self.client.cancel(query_handle)
> Could maybe use finally to run this on both code paths. Should this be clos
Done
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 00:21:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2162/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 00:53:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Thanks for fixing the padding, that should make things more consistent
http://gerrit.cloudera.org:8080/#/c/12524/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/3/tests/webserver/test_web_pages.py@124
PS3, Line 124: memz_breakdown = self.get_debug_page(self.MEMZ_URL)['detailed']
I think everything except close_query needs to be inside the try block - we don't want it to run if wait_for_state throws an exception, right?
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 00:32:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2166/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 01:49:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12524/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/1/tests/webserver/test_web_pages.py@124
PS1, Line 124: self.client.cancel(query_handle)
> Shouldn't we cancel the query after getting the memz output?
Good point, fixed. Looks like the cancelation was slow enough to work in my testing. :(
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:58:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12524/2/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/2/tests/webserver/test_web_pages.py@129
PS2, Line 129: self.client.cancel(query_handle)
Could maybe use finally to run this on both code paths. Should this be close_query() instead of cancel() as well to unregister the query?
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 19:42:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2164/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 01:22:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3797/
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 05:24:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 8: Code-Review+2
Fixed a test, carrying Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 20:13:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12524/2/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/2/tests/webserver/test_web_pages.py@123
PS2, Line 123: e
flake8: E722 do not use bare except'
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:58:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 20:54:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3796/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 00:42:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12524/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/1/tests/webserver/test_web_pages.py@124
PS1, Line 124: self.client.cancel(query_handle)
Shouldn't we cancel the query after getting the memz output?
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:17:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
This change also pads query IDs with zeros when printing them in the
backend.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Reviewed-on: http://gerrit.cloudera.org:8080/12524
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/runtime-state.cc
M be/src/util/debug-util-test.cc
M be/src/util/debug-util.cc
M tests/webserver/test_web_pages.py
4 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 10
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2157/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 19:15:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 00:30:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12524
to look at the new patch set (#8).
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
This change also pads query IDs with zeros when printing them in the
backend.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
---
M be/src/runtime/runtime-state.cc
M be/src/util/debug-util-test.cc
M be/src/util/debug-util.cc
M tests/webserver/test_web_pages.py
4 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12524/8
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3807/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 20:14:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 01:27:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3797/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 01:27:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Addressed Tim's last comment, carrying his +2.
http://gerrit.cloudera.org:8080/#/c/12524/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12524/3/tests/webserver/test_web_pages.py@124
PS3, Line 124: memz_breakdown = self.get_debug_page(self.MEMZ_URL)['detailed']
> I think everything except close_query needs to be inside the try block - we
You're right. Fixed it. m(
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 00:42:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12524
to look at the new patch set (#2).
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
---
M be/src/runtime/runtime-state.cc
M tests/webserver/test_web_pages.py
2 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12524/2
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2156/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:57:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12524
to look at the new patch set (#3).
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
IMPALA-8209: Include fragment instance ID in memz/ breakdown
The change for IMPALA-7694 had accidentally removed the fragment
instance ID from the memz/ breakdown. This change puts it back and adds
a test to make sure it's there.
This change also pads query IDs with zeros when printing them in the
backend.
Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
---
M be/src/runtime/runtime-state.cc
M be/src/util/debug-util.cc
M tests/webserver/test_web_pages.py
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12524/3
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8209: Include fragment instance ID in memz/ breakdown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown
......................................................................
Patch Set 6: Code-Review+2
Made a cosmetic improvement, carrying Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/12524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 01:27:30 +0000
Gerrit-HasComments: No