[GitHub] [tinkerpop] spmallette commented on pull request #1414: TINKERPOP-2245 Added UnifiedChannelizer

[GitBox <gi...@apache.org>]

spmallette commented on pull request #1414:
URL: https://github.com/apache/tinkerpop/pull/1414#issuecomment-817045551


   I've done a lot of work here and have largely addressed all your comments (hopefully). A few big ticket things to pay attention to:
   
   1. Despite my earlier reply, I went ahead and implemented rate limiting from https://issues.apache.org/jira/browse/TINKERPOP-709
   2. I renamed almost everything and which helped me to realized that i could kill some code which ended up getting rid of some "tasks" and "executors" and simplified some things. Basic structure now is that the `UnifiedHandler` (still not sure i want to go with the functional naming you suggested) creates a `SessionTask` which is submitted to a `Session` to be executed. The `Session` consumes a thread from the `gremlinPool` to do its work and is either a `SingleTaskSession` (meaning it executes the `SessionTask` that called for its creation and then completes) or is a `MultiTaskSession` (meaning it executes the initial `SessionTask` that called for its creation and then holds the thread awaiting more `SessionTask` instances to be submitted to it).
   3. Lots more javadoc that i hope is more clear and a lot more inline comments.
   
   Well, done with this for the weekend unless i'm struck by some fresh bit of thinking. I kinda like where it is. I think you're initial review helped refine things.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org