[GitHub] [lucene] uschindler commented on a change in pull request #487: LUCENE-10234: Change module prefix to org.apache.*

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758637522



##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -66,7 +66,7 @@ subprojects {
               "X-Build-JDK"           : "${System.properties['java.version']} (${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
               "X-Build-OS"            : "${System.properties['os.name']} ${System.properties['os.arch']} ${System.properties['os.version']}",
 
-              "Automatic-Module-Name" : "${-> project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}"
+              "Automatic-Module-Name" : "org.apache.${-> project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}"

Review comment:
       Can we do this like here, based on the Maven group?
   https://github.com/apache/lucene/blob/main/gradle/maven/publications-maven.gradle#L59-L60
   
   Of course, we would need to strip the ":lucene" from project path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org