[GitHub] [cordova-android] breautek commented on issue #822: Back button event on full screen video closes application

[GitBox <gi...@apache.org>]

breautek commented on issue #822: Back button event on full screen video closes application
URL: https://github.com/apache/cordova-android/issues/822#issuecomment-549049931
 
 
   @josephlodero 
   
   On the top of the github page in `cordova-android` repo, you can click on the `Fork` button, which will create a copy of this repo under your own account.
   
   Run the following commands, make sure you replace all `<variables>`. This should be done **outside** of your cordova project folder.
   
   ```
   git clone https://github.com/<your_github_username>/cordova-android.git
   cd cordova-android
   git checkout rel/8.1.0
   git branch backbuttonfix
   git checkout backbuttonfix
   git remote add Chuckytuh https://github.com/Chuckytuh/cordova-android.git
   git fetch Chuckytuh
   git merge Chuckytuh/fix/fullscreenbackbutton
   git push -u origin backbuttonfix
   ```
   
   The above clones your `cordova-android` fork, checks out the latest `8.1.0` release (for stability), creates a branch (because it's generally good practice to leave `master` branch clean), adds @Chuckytuh fork as a remote, so you can fetch his changes and then merge his branch into your branch. Then finally, you push your branch to your own repo. 
   
   Now you have a copy of `cordova-android` with the PR applied. To use it, we now have to replace your `cordova-android` install with your fork. So the following commands is done while inside your cordova project folder.
   
   ```
   cordova platform remove android
   cordova platform add https://github.com/<your_github_username>/cordova-android.git
   ```
   
   That should be it.
   
   @l-hwen 
   
   `framework/src/org/apache/cordova/CordovaWebViewImpl.java` is a filepath that only exists in the `cordova-android` repo, but it's not a filepath that exists on the installed `cordova-android` platform in a cordova project. So i'm not sure if you've done everything necessary to have the changeset apply in your project. I'd advise copying the same instructions as I provided @josephlodero
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org