svn commit: r1814743 - /jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/run/ThreadDumpCommand.java

[th...@apache.org]

Author: thomasm
Date: Thu Nov  9 16:40:52 2017
New Revision: 1814743

URL: http://svn.apache.org/viewvc?rev=1814743&view=rev
Log:
OAK-4521 Oak-run: add profiling and analysis tools

Modified:
    jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/run/ThreadDumpCommand.java

Modified: jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/run/ThreadDumpCommand.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/run/ThreadDumpCommand.java?rev=1814743&r1=1814742&r2=1814743&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/run/ThreadDumpCommand.java (original)
+++ jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/run/ThreadDumpCommand.java Thu Nov  9 16:40:52 2017
@@ -57,7 +57,10 @@ public class ThreadDumpCommand implement
         OptionSpec<Void> convertSpec = parser.accepts("convert",
                 "convert the thread dumps to the standard format");
         OptionSpec<Void> filterSpec = parser.accepts("filter",
-                "filter the thread dumps, only keep working threads");
+                "filter the thread dumps, only keep working (running), interesting threads " +
+                "(for example, threads that read from sockets are ignored, " +
+                "as they are typically waiting for input; " +
+                 "system threads such as GC are also ignored)");
         OptionSpec<Void> threadNamesSpec = parser.accepts("threadNames",
                 "create a summary of thread names");
         OptionSpec<Void> profileSpec = parser.accepts("profile",
@@ -72,7 +75,8 @@ public class ThreadDumpCommand implement
                 asList("h", "?", "help"), "show help").forHelp();
         OptionSet options = parser.parse(args);
         parser.nonOptions(
-                "file or directory containing thread dumps").ofType(File.class);
+                "file or directory containing thread dumps " +
+                "(ensure it does not contain other files, such as binaries)").ofType(File.class);
         if (options.has(helpSpec)
                 || options.nonOptionArguments().isEmpty()) {
             System.out.println("Mode: " + THREADDUMP);