[GitHub] [inlong] gong commented on a diff in pull request #4878: [INLONG-4875][Manager] Re-issue failed source task

[GitBox <gi...@apache.org>]

gong commented on code in PR #4878:
URL: https://github.com/apache/inlong/pull/4878#discussion_r914378926


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/AbstractSourceOperator.java:
##########
@@ -162,10 +162,11 @@ public void updateOpt(SourceRequest request, Integer groupStatus, String operato
         entity.setModifyTime(new Date());
 
         // Re-issue task if necessary
+        entity.setPreviousStatus(entity.getStatus());
         if (GroupStatus.forCode(groupStatus).equals(GroupStatus.CONFIG_SUCCESSFUL)) {
-            LOGGER.info("re-issuing source task {}, previous status = {}", entity.getId(), entity.getStatus());
-            entity.setPreviousStatus(entity.getStatus());
             entity.setStatus(SourceStatus.TO_BE_ISSUED_ADD.getCode());
+        } else {
+            entity.setStatus(SourceStatus.SOURCE_NEW.getCode());

Review Comment:
   Not `CONFIG_SUCCESSFUL`, code will set `SourceStatus.SOURCE_NEW`.   Do we need  set `SourceStatus.SOURCE_NEW` by judging status?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org