[GitHub] [myfaces] volosied commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier

["volosied (via GitHub)" <gi...@apache.org>]

volosied commented on PR #504:
URL: https://github.com/apache/myfaces/pull/504#issuecomment-1405997332

   This code addresses the issue found in the TCK, but it fails in our tests. You can find the failures in the build log, for example: 
   ```
   Error:  Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 2.055 s <<< FAILURE! - in org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase
   Error:  org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase.testFlow1_1  Time elapsed: 0.369 s  <<< FAILURE!
   java.lang.AssertionError: 
   expected null, but was:<<navigation-case>
     <from-view-id>/flow1_1.xhtml</from-view-id>
     <from-outcome>content</from-outcome>
     <to-view-id>/flow1/content.xhtml</to-view-id>
   </navigation-case>>
   	at org.junit.Assert.fail(Assert.java:89)
   	at org.junit.Assert.failNotNull(Assert.java:756)
   	at org.junit.Assert.assertNull(Assert.java:738)
   	at org.junit.Assert.assertNull(Assert.java:748)
   	at org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase.testFlow1_1(FlowMyFacesCDIRequestTestCase.java:72)
   ```
   
   https://github.com/apache/myfaces/blob/93a47f3c78716f0ff3c01227ee1cd5972aeb965b/impl/src/test/java/org/apache/myfaces/application/flow/FlowMyFacesCDIRequestTestCase.java#L59-L72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org