You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/04/28 10:15:32 UTC

[GitHub] [iceberg] Fokko opened a new issue, #7459: Python: Add code highlighting

Fokko opened a new issue, #7459:
URL: https://github.com/apache/iceberg/issues/7459

   ### Feature Request / Improvement
   
   It looks like we lost the colors on the code:
   ![image](https://user-images.githubusercontent.com/1134248/235121068-b83d3200-9755-4f5e-b0a2-3146af5b828c.png)
   
   Now everything is gray and makes it a bit harder to read.
   
   ### Query engine
   
   Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] Fokko commented on issue #7459: Python: Add code highlighting

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #7459:
URL: https://github.com/apache/iceberg/issues/7459#issuecomment-1529407250

   Nice! Works on my side as well, thanks for digging into this @DarthData410 
   
   ![image](https://user-images.githubusercontent.com/1134248/235418121-5a7a72b3-a0d0-48ff-9251-c87fcdbca1bd.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] Fokko closed issue #7459: Python: Add code highlighting

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #7459: Python: Add code highlighting
URL: https://github.com/apache/iceberg/issues/7459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] DarthData410 commented on issue #7459: Python: Add code highlighting

Posted by "DarthData410 (via GitHub)" <gi...@apache.org>.
DarthData410 commented on issue #7459:
URL: https://github.com/apache/iceberg/issues/7459#issuecomment-1529160873

   Alright so this is a theme configuration in mkdocs.yml was not completely setup for python code highlighting, pure the theme being used 'material'.
   mkdocs-material theme: https://squidfunk.github.io/mkdocs-material/setup/extensions/python-markdown-extensions/?h=highlight+js#highlight
   
    
   ![Screenshot from 2023-04-30 18-01-57](https://user-images.githubusercontent.com/119692461/235380033-43e7a48c-8ea9-4984-8285-5d00c93f716e.png)
   
   Have a look at what I generated, after applying the correct updates for the mkdocs.yml file. The code highlighting is now in place. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] DarthData410 commented on issue #7459: Python: Add code highlighting

Posted by "DarthData410 (via GitHub)" <gi...@apache.org>.
DarthData410 commented on issue #7459:
URL: https://github.com/apache/iceberg/issues/7459#issuecomment-1529130233

   Feel free to assign this to me, and I will get this completed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org