You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by anmolnar <gi...@git.apache.org> on 2018/04/27 14:53:15 UTC

[GitHub] zookeeper pull request #509: ZOOKEEPER-3027 Accidently removed public API of...

GitHub user anmolnar opened a pull request:

    https://github.com/apache/zookeeper/pull/509

    ZOOKEEPER-3027 Accidently removed public API of FileTxnLog.setPreallocSize()

    In my latest commit regarding TxnLogToolkit there's a refactor to outsource file padding logic from FileTxnLog to a separate class:
    
    https://github.com/apache/zookeeper/commit/126fb0f22d701cad58bf3123bf7d8f2219e60387#diff-89717124564925d61d29dd817bcdd915
    
    Unfortunately public static method setPreallocSize(int) has also been moved to the new class, but it's being actively used by hadoop-common project too:
    
    https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/ClientBaseWithFixes.java#L384
    
    I'd like to submit a patch to revert the deleted method which is going to call the new one, but will keep backward compatibility with Hadoop.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #509
    
----
commit 871480dff9b4b106a2a7bdfc6ab720436a6a5042
Author: Andor Molnar <an...@...>
Date:   2018-04-27T14:51:40Z

    ZOOKEEPER-3027. Added back FileTxnLog.setPreallocSize() + unit test

----


---

[GitHub] zookeeper pull request #509: ZOOKEEPER-3027 Accidently removed public API of...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/509


---

[GitHub] zookeeper issue #509: ZOOKEEPER-3027 Accidently removed public API of FileTx...

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/509
  
    @phunt all commits lgtm +1
    thanks.



---

[GitHub] zookeeper issue #509: ZOOKEEPER-3027 Accidently removed public API of FileTx...

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/509
  
    +1, good catch. I committed this to all three active branches - please take a look at 3.4 branch commit as I did need to resolve a conflict. (seemed minor and tests are passing)


---