You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/06 03:01:07 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4433: net/devif/devif_callback.c: corrected the connection event list to work as FIFO instead of LIFO

xiaoxiang781216 commented on a change in pull request #4433:
URL: https://github.com/apache/incubator-nuttx/pull/4433#discussion_r698156531



##########
File path: net/devif/devif.h
##########
@@ -260,6 +260,9 @@ typedef CODE uint16_t (*devif_callback_event_t)(FAR struct net_driver_s *dev,
 struct devif_callback_s
 {
   FAR struct devif_callback_s *nxtconn;
+  FAR struct devif_callback_s *tail_helper; /* The tail helper field is used

Review comment:
       since the list is short normally, why not search the tail directly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org