You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sc...@apache.org on 2003/10/06 01:21:07 UTC

cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/iterators ArrayListIterator.java

scolebourne    2003/10/05 16:21:07

  Modified:    collections/src/test/org/apache/commons/collections
                        TestNodeCachingLinkedList.java
                        TestCommonsLinkedList.java
               collections/src/test/org/apache/commons/collections/comparators
                        TestBooleanComparator.java
               collections/src/java/org/apache/commons/collections/comparators
                        BooleanComparator.java
               collections/src/java/org/apache/commons/collections/iterators
                        ArrayListIterator.java
  Log:
  Update version numbers for next release
  
  Revision  Changes    Path
  1.7       +3 -3      jakarta-commons/collections/src/test/org/apache/commons/collections/TestNodeCachingLinkedList.java
  
  Index: TestNodeCachingLinkedList.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestNodeCachingLinkedList.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- TestNodeCachingLinkedList.java	5 Oct 2003 21:23:21 -0000	1.6
  +++ TestNodeCachingLinkedList.java	5 Oct 2003 23:21:07 -0000	1.7
  @@ -89,7 +89,7 @@
       }
       
       public String getCompatibilityVersion() {
  -        return "2.2";
  +        return "3.0";
       }
       
       public void testShrinkCache() {
  
  
  
  1.6       +3 -3      jakarta-commons/collections/src/test/org/apache/commons/collections/TestCommonsLinkedList.java
  
  Index: TestCommonsLinkedList.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestCommonsLinkedList.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- TestCommonsLinkedList.java	5 Oct 2003 21:11:06 -0000	1.5
  +++ TestCommonsLinkedList.java	5 Oct 2003 23:21:07 -0000	1.6
  @@ -88,7 +88,7 @@
       }
       
       public String getCompatibilityVersion() {
  -        return "2.2";
  +        return "3.0";
       }
       
       public void setUp() {
  
  
  
  1.5       +3 -3      jakarta-commons/collections/src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java
  
  Index: TestBooleanComparator.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- TestBooleanComparator.java	1 Oct 2003 22:14:48 -0000	1.4
  +++ TestBooleanComparator.java	5 Oct 2003 23:21:07 -0000	1.5
  @@ -103,7 +103,7 @@
       }
       
       public String getCompatibilityVersion() {
  -        return "2.2";
  +        return "3.0";
       }
   
       // tests
  
  
  
  1.8       +2 -3      jakarta-commons/collections/src/java/org/apache/commons/collections/comparators/BooleanComparator.java
  
  Index: BooleanComparator.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/comparators/BooleanComparator.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- BooleanComparator.java	31 Aug 2003 17:25:49 -0000	1.7
  +++ BooleanComparator.java	5 Oct 2003 23:21:07 -0000	1.8
  @@ -68,7 +68,6 @@
    * @see #getBooleanComparator
    * 
    * @since Commons Collections 3.0
  - * 
    * @version $Revision$ $Date$
    * 
    * @author Rodney Waldhoff
  
  
  
  1.7       +4 -4      jakarta-commons/collections/src/java/org/apache/commons/collections/iterators/ArrayListIterator.java
  
  Index: ArrayListIterator.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/iterators/ArrayListIterator.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ArrayListIterator.java	29 Sep 2003 22:37:40 -0000	1.6
  +++ ArrayListIterator.java	5 Oct 2003 23:21:07 -0000	1.7
  @@ -76,10 +76,10 @@
    * @see java.util.Iterator
    * @see java.util.ListIterator
    *
  - * @since Commons Collections 2.2
  + * @since Commons Collections 3.0
    * @version $Revision$ $Date$
    *
  - * @author <a href="mailto:neilotoole@users.sourceforge.net">Neil O'Toole</a>
  + * @author Neil O'Toole
    * @author Stephen Colebourne
    * @author Phil Steitz
    */
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/iterators ArrayListIterator.java

Posted by Stephen Colebourne <sc...@btopenworld.com>.
Yeh, this should all be sorted now.
Stephen

----- Original Message -----
From: "Robert Leland" <rl...@apache.org>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Monday, October 06, 2003 3:55 AM
Subject: Re: cvs commit:
jakarta-commons/collections/src/java/org/apache/commons/collections/iterator
s ArrayListIterator.java


> Phil Steitz wrote:
>
> jakarta-commons\collections\data\test
>
> seems to have test data with a version number. My guess is cloning the
> data and substuting
> NullComparator.version2.obj2
> NullComparator.version3.obj
>
> Might work
>
> > The changes to getCompatabilityVersion() below seem to be causing the
> > compatability tests to fail.  I am getting errors like the following
now:
> >
> > [java] 1)
> >
testEmptyListCompatibility(TestCommonsLinkedList.testEmptyListCompatibility)
> > java.io.FileNotFoundException:
> > data/test/CommonsLinkedList.emptyCollection.version3.0.obj (No such
> > file or directory)
> >      [java]     at java.io.FileInputStream.open(Native Method)
> >      [java]     at
> > java.io.FileInputStream.<init>(FileInputStream.java:106)
> >      [java]     at
> > java.io.FileInputStream.<init>(FileInputStream.java:66)
> >      [java]     at
> >
org.apache.commons.collections.AbstractTestObject.readExternalFormFromDisk(A
bstractTestObject.java:317)
> >
> >      [java]     at
> >
org.apache.commons.collections.AbstractTestList.testEmptyListCompatibility(A
bstractTestList.java:974)
> >
> >      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> >      [java]     at
> >
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
> >
> >      [java]     at
> >
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
> >
> >
> > I have no clue how to fix this....(other than to change the values
> > back to 2.2, which makes the problem go away ;-)
> >
> > I am also now getting multiple failures for TestHashBidiMap.
> >
> > Phil
> >
> >
> >
> > scolebourne@apache.org wrote:
> >
> >> scolebourne    2003/10/05 16:21:07
> >>
> >>   Modified:    collections/src/test/org/apache/commons/collections
> >>                         TestNodeCachingLinkedList.java
> >>                         TestCommonsLinkedList.java
> >>
> >> collections/src/test/org/apache/commons/collections/comparators
> >>                         TestBooleanComparator.java
> >>
> >> collections/src/java/org/apache/commons/collections/comparators
> >>                         BooleanComparator.java
> >>
> >> collections/src/java/org/apache/commons/collections/iterators
> >>                         ArrayListIterator.java
> >>   Log:
> >>   Update version numbers for next release
> >>     Revision  Changes    Path
> >>   1.7       +3 -3
> >>
jakarta-commons/collections/src/test/org/apache/commons/collections/TestNode
CachingLinkedList.java
> >>
> >>     Index: TestNodeCachingLinkedList.java
> >>   ===================================================================
> >>   RCS file:
> >>
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collection
s/TestNodeCachingLinkedList.java,v
> >>
> >>   retrieving revision 1.6
> >>   retrieving revision 1.7
> >>   diff -u -r1.6 -r1.7
> >>   --- TestNodeCachingLinkedList.java    5 Oct 2003 21:23:21 -0000
1.6
> >>   +++ TestNodeCachingLinkedList.java    5 Oct 2003 23:21:07 -0000
1.7
> >>   @@ -89,7 +89,7 @@
> >>        }
> >>               public String getCompatibilityVersion() {
> >>   -        return "2.2";
> >>   +        return "3.0";
> >>        }
> >>               public void testShrinkCache() {
> >>         1.6       +3 -3
> >>
jakarta-commons/collections/src/test/org/apache/commons/collections/TestComm
onsLinkedList.java
> >>
> >>     Index: TestCommonsLinkedList.java
> >>   ===================================================================
> >>   RCS file:
> >>
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collection
s/TestCommonsLinkedList.java,v
> >>
> >>   retrieving revision 1.5
> >>   retrieving revision 1.6
> >>   diff -u -r1.5 -r1.6
> >>   --- TestCommonsLinkedList.java    5 Oct 2003 21:11:06 -0000    1.5
> >>   +++ TestCommonsLinkedList.java    5 Oct 2003 23:21:07 -0000    1.6
> >>   @@ -88,7 +88,7 @@
> >>        }
> >>               public String getCompatibilityVersion() {
> >>   -        return "2.2";
> >>   +        return "3.0";
> >>        }
> >>               public void setUp() {
> >>         1.5       +3 -3
> >>
jakarta-commons/collections/src/test/org/apache/commons/collections/comparat
ors/TestBooleanComparator.java
> >>
> >>     Index: TestBooleanComparator.java
> >>   ===================================================================
> >>   RCS file:
> >>
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collection
s/comparators/TestBooleanComparator.java,v
> >>
> >>   retrieving revision 1.4
> >>   retrieving revision 1.5
> >>   diff -u -r1.4 -r1.5
> >>   --- TestBooleanComparator.java    1 Oct 2003 22:14:48 -0000    1.4
> >>   +++ TestBooleanComparator.java    5 Oct 2003 23:21:07 -0000    1.5
> >>   @@ -103,7 +103,7 @@
> >>        }
> >>               public String getCompatibilityVersion() {
> >>   -        return "2.2";
> >>   +        return "3.0";
> >>        }
> >>           // tests
> >>
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/iterators ArrayListIterator.java

Posted by Robert Leland <rl...@apache.org>.
Phil Steitz wrote:

jakarta-commons\collections\data\test

seems to have test data with a version number. My guess is cloning the 
data and substuting
NullComparator.version2.obj2
NullComparator.version3.obj

Might work

> The changes to getCompatabilityVersion() below seem to be causing the 
> compatability tests to fail.  I am getting errors like the following now:
>
> [java] 1) 
> testEmptyListCompatibility(TestCommonsLinkedList.testEmptyListCompatibility) 
> java.io.FileNotFoundException: 
> data/test/CommonsLinkedList.emptyCollection.version3.0.obj (No such 
> file or directory)
>      [java]     at java.io.FileInputStream.open(Native Method)
>      [java]     at 
> java.io.FileInputStream.<init>(FileInputStream.java:106)
>      [java]     at 
> java.io.FileInputStream.<init>(FileInputStream.java:66)
>      [java]     at 
> org.apache.commons.collections.AbstractTestObject.readExternalFormFromDisk(AbstractTestObject.java:317) 
>
>      [java]     at 
> org.apache.commons.collections.AbstractTestList.testEmptyListCompatibility(AbstractTestList.java:974) 
>
>      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
>      [java]     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) 
>
>      [java]     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 
>
>
> I have no clue how to fix this....(other than to change the values 
> back to 2.2, which makes the problem go away ;-)
>
> I am also now getting multiple failures for TestHashBidiMap.
>
> Phil
>
>
>
> scolebourne@apache.org wrote:
>
>> scolebourne    2003/10/05 16:21:07
>>
>>   Modified:    collections/src/test/org/apache/commons/collections
>>                         TestNodeCachingLinkedList.java
>>                         TestCommonsLinkedList.java
>>                
>> collections/src/test/org/apache/commons/collections/comparators
>>                         TestBooleanComparator.java
>>                
>> collections/src/java/org/apache/commons/collections/comparators
>>                         BooleanComparator.java
>>                
>> collections/src/java/org/apache/commons/collections/iterators
>>                         ArrayListIterator.java
>>   Log:
>>   Update version numbers for next release
>>     Revision  Changes    Path
>>   1.7       +3 -3      
>> jakarta-commons/collections/src/test/org/apache/commons/collections/TestNodeCachingLinkedList.java 
>>
>>     Index: TestNodeCachingLinkedList.java
>>   ===================================================================
>>   RCS file: 
>> /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestNodeCachingLinkedList.java,v 
>>
>>   retrieving revision 1.6
>>   retrieving revision 1.7
>>   diff -u -r1.6 -r1.7
>>   --- TestNodeCachingLinkedList.java    5 Oct 2003 21:23:21 -0000    1.6
>>   +++ TestNodeCachingLinkedList.java    5 Oct 2003 23:21:07 -0000    1.7
>>   @@ -89,7 +89,7 @@
>>        }
>>               public String getCompatibilityVersion() {
>>   -        return "2.2";
>>   +        return "3.0";
>>        }
>>               public void testShrinkCache() {
>>         1.6       +3 -3      
>> jakarta-commons/collections/src/test/org/apache/commons/collections/TestCommonsLinkedList.java 
>>
>>     Index: TestCommonsLinkedList.java
>>   ===================================================================
>>   RCS file: 
>> /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestCommonsLinkedList.java,v 
>>
>>   retrieving revision 1.5
>>   retrieving revision 1.6
>>   diff -u -r1.5 -r1.6
>>   --- TestCommonsLinkedList.java    5 Oct 2003 21:11:06 -0000    1.5
>>   +++ TestCommonsLinkedList.java    5 Oct 2003 23:21:07 -0000    1.6
>>   @@ -88,7 +88,7 @@
>>        }
>>               public String getCompatibilityVersion() {
>>   -        return "2.2";
>>   +        return "3.0";
>>        }
>>               public void setUp() {
>>         1.5       +3 -3      
>> jakarta-commons/collections/src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java 
>>
>>     Index: TestBooleanComparator.java
>>   ===================================================================
>>   RCS file: 
>> /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java,v 
>>
>>   retrieving revision 1.4
>>   retrieving revision 1.5
>>   diff -u -r1.4 -r1.5
>>   --- TestBooleanComparator.java    1 Oct 2003 22:14:48 -0000    1.4
>>   +++ TestBooleanComparator.java    5 Oct 2003 23:21:07 -0000    1.5
>>   @@ -103,7 +103,7 @@
>>        }
>>               public String getCompatibilityVersion() {
>>   -        return "2.2";
>>   +        return "3.0";
>>        }
>>           // tests
>>     
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/iterators ArrayListIterator.java

Posted by Phil Steitz <ph...@steitz.com>.
The changes to getCompatabilityVersion() below seem to be causing the 
compatability tests to fail.  I am getting errors like the following now:

[java] 1) 
testEmptyListCompatibility(TestCommonsLinkedList.testEmptyListCompatibility) 
java.io.FileNotFoundException: 
data/test/CommonsLinkedList.emptyCollection.version3.0.obj (No such file 
or directory)
      [java] 	at java.io.FileInputStream.open(Native Method)
      [java] 	at java.io.FileInputStream.<init>(FileInputStream.java:106)
      [java] 	at java.io.FileInputStream.<init>(FileInputStream.java:66)
      [java] 	at 
org.apache.commons.collections.AbstractTestObject.readExternalFormFromDisk(AbstractTestObject.java:317)
      [java] 	at 
org.apache.commons.collections.AbstractTestList.testEmptyListCompatibility(AbstractTestList.java:974)
      [java] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      [java] 	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      [java] 	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

I have no clue how to fix this....(other than to change the values back 
to 2.2, which makes the problem go away ;-)

I am also now getting multiple failures for TestHashBidiMap.

Phil



scolebourne@apache.org wrote:
> scolebourne    2003/10/05 16:21:07
> 
>   Modified:    collections/src/test/org/apache/commons/collections
>                         TestNodeCachingLinkedList.java
>                         TestCommonsLinkedList.java
>                collections/src/test/org/apache/commons/collections/comparators
>                         TestBooleanComparator.java
>                collections/src/java/org/apache/commons/collections/comparators
>                         BooleanComparator.java
>                collections/src/java/org/apache/commons/collections/iterators
>                         ArrayListIterator.java
>   Log:
>   Update version numbers for next release
>   
>   Revision  Changes    Path
>   1.7       +3 -3      jakarta-commons/collections/src/test/org/apache/commons/collections/TestNodeCachingLinkedList.java
>   
>   Index: TestNodeCachingLinkedList.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestNodeCachingLinkedList.java,v
>   retrieving revision 1.6
>   retrieving revision 1.7
>   diff -u -r1.6 -r1.7
>   --- TestNodeCachingLinkedList.java	5 Oct 2003 21:23:21 -0000	1.6
>   +++ TestNodeCachingLinkedList.java	5 Oct 2003 23:21:07 -0000	1.7
>   @@ -89,7 +89,7 @@
>        }
>        
>        public String getCompatibilityVersion() {
>   -        return "2.2";
>   +        return "3.0";
>        }
>        
>        public void testShrinkCache() {
>   
>   
>   
>   1.6       +3 -3      jakarta-commons/collections/src/test/org/apache/commons/collections/TestCommonsLinkedList.java
>   
>   Index: TestCommonsLinkedList.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestCommonsLinkedList.java,v
>   retrieving revision 1.5
>   retrieving revision 1.6
>   diff -u -r1.5 -r1.6
>   --- TestCommonsLinkedList.java	5 Oct 2003 21:11:06 -0000	1.5
>   +++ TestCommonsLinkedList.java	5 Oct 2003 23:21:07 -0000	1.6
>   @@ -88,7 +88,7 @@
>        }
>        
>        public String getCompatibilityVersion() {
>   -        return "2.2";
>   +        return "3.0";
>        }
>        
>        public void setUp() {
>   
>   
>   
>   1.5       +3 -3      jakarta-commons/collections/src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java
>   
>   Index: TestBooleanComparator.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java,v
>   retrieving revision 1.4
>   retrieving revision 1.5
>   diff -u -r1.4 -r1.5
>   --- TestBooleanComparator.java	1 Oct 2003 22:14:48 -0000	1.4
>   +++ TestBooleanComparator.java	5 Oct 2003 23:21:07 -0000	1.5
>   @@ -103,7 +103,7 @@
>        }
>        
>        public String getCompatibilityVersion() {
>   -        return "2.2";
>   +        return "3.0";
>        }
>    
>        // tests
>   
>   




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org