You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Cai-Yao (via GitHub)" <gi...@apache.org> on 2023/04/25 08:00:29 UTC
[GitHub] [doris] Cai-Yao opened a new pull request, #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Cai-Yao opened a new pull request, #19056:
URL: https://github.com/apache/doris/pull/19056
# Proposed changes
Issue Number: close #xxx
## Problem summary
### Before
```
_desc_result.columns[i].columnDesc.columnLength
```
### After
```
static_cast<int64_t>(_desc_result.columns[i].columnDesc.columnLength) * 4
```
avoid 2147483643 * 4 = -20
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521968016
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521382116
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521347189
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19056:
URL: https://github.com/apache/doris/pull/19056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Cai-Yao commented on a diff in pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "Cai-Yao (via GitHub)" <gi...@apache.org>.
Cai-Yao commented on code in PR #19056:
URL: https://github.com/apache/doris/pull/19056#discussion_r1176175668
##########
be/src/exec/schema_scanner/schema_columns_scanner.cpp:
##########
@@ -455,7 +455,9 @@ Status SchemaColumnsScanner::_fill_block_impl(vectorized::Block* block) {
if (data_type == TPrimitiveType::VARCHAR || data_type == TPrimitiveType::CHAR ||
data_type == TPrimitiveType::STRING) {
if (_desc_result.columns[i].columnDesc.__isset.columnLength) {
- srcs[i] = _desc_result.columns[i].columnDesc.columnLength * 4;
+ srcs[i] =
+ static_cast<int64_t>(_desc_result.columns[i].columnDesc.columnLength) *
+ 4;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521405547
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on a diff in pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on code in PR #19056:
URL: https://github.com/apache/doris/pull/19056#discussion_r1176160153
##########
be/src/exec/schema_scanner/schema_columns_scanner.cpp:
##########
@@ -455,7 +455,9 @@ Status SchemaColumnsScanner::_fill_block_impl(vectorized::Block* block) {
if (data_type == TPrimitiveType::VARCHAR || data_type == TPrimitiveType::CHAR ||
data_type == TPrimitiveType::STRING) {
if (_desc_result.columns[i].columnDesc.__isset.columnLength) {
- srcs[i] = _desc_result.columns[i].columnDesc.columnLength * 4;
+ srcs[i] =
+ static_cast<int64_t>(_desc_result.columns[i].columnDesc.columnLength) *
+ 4;
Review Comment:
seems could use `length * 4L`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521405341
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521383872
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Cai-Yao commented on pull request #19056: [Fix](schema scanner) Fixed the problem of overflow when multiplying two INT
Posted by "Cai-Yao (via GitHub)" <gi...@apache.org>.
Cai-Yao commented on PR #19056:
URL: https://github.com/apache/doris/pull/19056#issuecomment-1521596156
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org