You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/07/27 01:23:10 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1107: Fix: Account lock history never be remove

tianxiaoliang commented on a change in pull request #1107:
URL: https://github.com/apache/servicecomb-service-center/pull/1107#discussion_r677048353



##########
File path: server/job/account/account.go
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package account
+
+import (
+	"context"
+	"fmt"
+	"time"
+
+	"github.com/apache/servicecomb-service-center/pkg/gopool"
+	"github.com/apache/servicecomb-service-center/pkg/log"
+	accountsvc "github.com/apache/servicecomb-service-center/server/service/account"
+)
+
+const releasedLockHistoryCleanupInterval = 5 * time.Minute
+
+func init() {
+	startReleasedLockHistoryCleanupJob()
+}
+
+// startReleasedLockHistoryCleanupJob cause of accountsvc.IsBanned may be never called
+// after locked account, then run a job to cleanup the released lock
+func startReleasedLockHistoryCleanupJob() {
+	log.Info(fmt.Sprintf("start released lock history cleanup job(every %s)", releasedLockHistoryCleanupInterval))
+	gopool.Go(func(ctx context.Context) {
+		tick := time.NewTicker(releasedLockHistoryCleanupInterval)
+		defer tick.Stop()
+		for {
+			select {
+			case <-ctx.Done():
+				return
+			case <-tick.C:
+				err := CleanupReleasedLockHistory(ctx)
+				if err != nil {
+					log.Error("cleanup lock history failed", err)
+				}
+			}
+		}
+	})
+}
+
+func CleanupReleasedLockHistory(ctx context.Context) error {
+	locks, n, err := accountsvc.ListLock(ctx)
+	if err != nil {
+		return err
+	}
+	if n == 0 {
+		return nil
+	}
+	removeN := 0
+	for _, lock := range locks {
+		if lock.ReleaseAt > time.Now().Unix() {
+			continue
+		}
+		err := accountsvc.DeleteLock(ctx, lock.Key)

Review comment:
       执行效率太低了,能否用delete in 每次传10个ID




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org