You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@newton.collab.net> on 2000/11/07 13:26:58 UTC

Re: CVS update: subversion/subversion/libsvn_wc/tests checkout-test.c

gstein@tigris.org writes:

>   Log:
>   don't use apr_canonical_error() -- its continued existence is questionable
>   

Why?

Re: CVS update: subversion/subversion/libsvn_wc/tests checkout-test.c

Posted by Greg Stein <gs...@lyra.org>.
On Tue, Nov 07, 2000 at 07:26:58AM -0600, Ben Collins-Sussman wrote:
> gstein@tigris.org writes:
> >   Log:
> >   don't use apr_canonical_error() -- its continued existence is questionable
> 
> Why?

The APR_STATUS_IS_*() macros are intended to replace uses of
apr_canonical_error(). What was happening is that canonical_error had this
huge switching, which was growing and growing. From an efficiency
standpoint, the macros are much better.

While I can't say that apr_canonical_error is definitely going away, I know
that every single usage has been wiped from Apache. IOW, it certainly has no
value right now, and it will probably suffer bit-rot over time (so it should
just go away now).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/