You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:32:57 UTC

[GitHub] [superset] prosdev0107 commented on a diff in pull request #19673: fix(import): make to add the error alert

prosdev0107 commented on code in PR #19673:
URL: https://github.com/apache/superset/pull/19673#discussion_r849624909


##########
superset-frontend/src/components/ImportModal/index.tsx:
##########
@@ -142,7 +154,7 @@ const ImportModelsModal: FunctionComponent<ImportModelsModalProps> = ({
 
   const handleErrorMsg = (msg: string) => {
     clearModal();
-    addDangerToast(msg);
+    setErrMsg(msg);

Review Comment:
   For double confirming, you mean that we should clear error message when attempting a new file upload?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org