You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2020/07/09 06:55:12 UTC
[groovy] 04/05: Trivial refactoring: avoid redundant method calls
This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
commit a597dc29fb6d392d0e1241f7b58240177503c5c2
Author: Daniel Sun <su...@apache.org>
AuthorDate: Thu Jul 9 14:31:54 2020 +0800
Trivial refactoring: avoid redundant method calls
---
.../org/codehaus/groovy/tools/javac/JavaStubGenerator.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/codehaus/groovy/tools/javac/JavaStubGenerator.java b/src/main/java/org/codehaus/groovy/tools/javac/JavaStubGenerator.java
index ead34a9..6e32363 100644
--- a/src/main/java/org/codehaus/groovy/tools/javac/JavaStubGenerator.java
+++ b/src/main/java/org/codehaus/groovy/tools/javac/JavaStubGenerator.java
@@ -376,10 +376,10 @@ public class JavaStubGenerator {
// skip values() method and valueOf(String)
String name = method.getName();
Parameter[] params = method.getParameters();
- if (name.equals("values") && params.length == 0) continue;
- if (name.equals("valueOf") &&
- params.length == 1 &&
- params[0].getType().equals(ClassHelper.STRING_TYPE)) {
+ if (params.length == 0 && name.equals("values")) continue;
+ if (params.length == 1
+ && name.equals("valueOf")
+ && params[0].getType().equals(ClassHelper.STRING_TYPE)) {
continue;
}
}
@@ -459,8 +459,9 @@ public class JavaStubGenerator {
boolean isInterface = isInterfaceOrTrait(classNode);
List<FieldNode> fields = classNode.getFields();
if (fields == null) return;
- List<FieldNode> enumFields = new ArrayList<FieldNode>(fields.size());
- List<FieldNode> normalFields = new ArrayList<FieldNode>(fields.size());
+ final int fieldCnt = fields.size();
+ List<FieldNode> enumFields = new ArrayList<FieldNode>(fieldCnt);
+ List<FieldNode> normalFields = new ArrayList<FieldNode>(fieldCnt);
for (FieldNode field : fields) {
boolean isSynthetic = (field.getModifiers() & Opcodes.ACC_SYNTHETIC) != 0;
if (field.isEnum()) {