You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2016/04/07 21:54:33 UTC

[GitHub] cloudstack pull request: Fix deleting template from UI

GitHub user remibergsma opened a pull request:

    https://github.com/apache/cloudstack/pull/1476

    Fix deleting template from UI

    It failed because zoneid was zero. Added a check for it and only send it when it makes sense.
    
    With zoneid:
    ![screen shot 2016-03-29 at 21 40 11](https://cloud.githubusercontent.com/assets/1630096/14121676/b5bb1b0c-f5f8-11e5-88c4-c9fe28b55a21.png)
    
    Without:
    ![screen shot 2016-03-29 at 21 43 16](https://cloud.githubusercontent.com/assets/1630096/14121681/b90477cc-f5f8-11e5-8501-9ad6f0a350bd.png)
    
    Both result in:
    ![screen shot 2016-03-29 at 21 43 27](https://cloud.githubusercontent.com/assets/1630096/14121683/bd955bbc-f5f8-11e5-88ea-779569eac69b.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remibergsma/cloudstack 47_fix_del_template_s3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1476
    
----
commit 503afad7d22ccf105eef1c19bf8ff5729209ca19
Author: Remi Bergsma <gi...@remi.nl>
Date:   2016-04-07T19:52:57Z

    Fix deleting template from UI
    
    Backport from Cosmic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix deleting template from UI

Posted by remibergsma <gi...@git.apache.org>.

Github user remibergsma closed the pull request at:

    https://github.com/apache/cloudstack/pull/1476


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix deleting template from UI

Posted by pdube <gi...@git.apache.org>.

Github user pdube commented on the pull request:

    https://github.com/apache/cloudstack/pull/1476#issuecomment-213116347
  
    Hey @remibergsma  just noticed that you had a PR open for this. I fixed it as well with #1505 so we might be able to close this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---