You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Karen Miller <km...@pivotal.io> on 2016/10/20 17:49:36 UTC
Review Request 53072: GEODE-2019 Add automated rebalance documentation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53072/
-----------------------------------------------------------
Review request for geode, Dave Barnes and Joey McAllister.
Repository: geode
Description
-------
GEODE-2019 Add automated rebalance documentation
Diffs
-----
geode-book/master_middleman/source/subnavs/geode-subnav.erb 53e9118136e4898d0e9ec4e7a30512f3d6bce3ce
geode-docs/developing/partitioned_regions/automated_rebalance.html.md.erb PRE-CREATION
geode-docs/developing/partitioned_regions/chapter_overview.html.md.erb c92921b7b8f6adc416ccfab00df8ce51e9bbd113
Diff: https://reviews.apache.org/r/53072/diff/
Testing
-------
Thanks,
Karen Miller
Re: Review Request 53072: GEODE-2019 Add automated rebalance
documentation
Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53072/#review153472
-----------------------------------------------------------
Ship it!
Ship It!
- Dave Barnes
On Oct. 20, 2016, 9:22 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53072/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 9:22 p.m.)
>
>
> Review request for geode, Dave Barnes and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2019 Add automated rebalance documentation
>
>
> Diffs
> -----
>
> geode-docs/developing/partitioned_regions/automated_rebalance.html.md.erb PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53072/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 53072: GEODE-2019 Add automated rebalance
documentation
Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53072/#review153477
-----------------------------------------------------------
Ship it!
Ship It!
- Joey McAllister
On Oct. 20, 2016, 9:22 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53072/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 9:22 p.m.)
>
>
> Review request for geode, Dave Barnes and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2019 Add automated rebalance documentation
>
>
> Diffs
> -----
>
> geode-docs/developing/partitioned_regions/automated_rebalance.html.md.erb PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53072/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 53072: GEODE-2019 Add automated rebalance
documentation
Posted by Karen Miller <km...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53072/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 9:22 p.m.)
Review request for geode, Dave Barnes and Joey McAllister.
Repository: geode
Description
-------
GEODE-2019 Add automated rebalance documentation
Diffs (updated)
-----
geode-docs/developing/partitioned_regions/automated_rebalance.html.md.erb PRE-CREATION
Diff: https://reviews.apache.org/r/53072/diff/
Testing
-------
Thanks,
Karen Miller
Re: Review Request 53072: GEODE-2019 Add automated rebalance
documentation
Posted by Karen Miller <km...@pivotal.io>.
> On Oct. 20, 2016, 8:35 p.m., Dave Barnes wrote:
> > I notice a slight mismatch in titles. The subnav and chapter overview links to this section say "Automated Rebalancing of Partitioned Region Data", while the section itself is entitled simply "Automated Rebalance".
> >
> > I'm thinking that as a reader I'd like these to match. Would that constitute needless hobgoblin consistency?
No hobgoblins around here. A further commit has implemented the change suggested. Let me know if you think this is now ready to commit.
- Karen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53072/#review153449
-----------------------------------------------------------
On Oct. 20, 2016, 9:22 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53072/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 9:22 p.m.)
>
>
> Review request for geode, Dave Barnes and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2019 Add automated rebalance documentation
>
>
> Diffs
> -----
>
> geode-docs/developing/partitioned_regions/automated_rebalance.html.md.erb PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53072/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 53072: GEODE-2019 Add automated rebalance
documentation
Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53072/#review153449
-----------------------------------------------------------
I notice a slight mismatch in titles. The subnav and chapter overview links to this section say "Automated Rebalancing of Partitioned Region Data", while the section itself is entitled simply "Automated Rebalance".
I'm thinking that as a reader I'd like these to match. Would that constitute needless hobgoblin consistency?
- Dave Barnes
On Oct. 20, 2016, 5:49 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53072/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 5:49 p.m.)
>
>
> Review request for geode, Dave Barnes and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2019 Add automated rebalance documentation
>
>
> Diffs
> -----
>
> geode-book/master_middleman/source/subnavs/geode-subnav.erb 53e9118136e4898d0e9ec4e7a30512f3d6bce3ce
> geode-docs/developing/partitioned_regions/automated_rebalance.html.md.erb PRE-CREATION
> geode-docs/developing/partitioned_regions/chapter_overview.html.md.erb c92921b7b8f6adc416ccfab00df8ce51e9bbd113
>
> Diff: https://reviews.apache.org/r/53072/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karen Miller
>
>