[GitHub] [iceberg] flyrain commented on a change in pull request #2500: Spark: Add SparkRewriteBuilder for rewriting a set of files

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #2500:
URL: https://github.com/apache/iceberg/pull/2500#discussion_r617804798



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java
##########
@@ -47,4 +47,7 @@ private SparkWriteOptions() {
 
   // Checks if input schema and table schema are same(default: true)
   public static final String CHECK_ORDERING = "check-ordering";
+
+  // File scan task set ID that is being rewritten
+  public static final String REWRITTEN_FILE_SCAN_TASK_SET_ID = "rewritten-file-scan-task-set-id";

Review comment:
       Could you comment it here why the file scan task set id is required? Maybe I don't have enough context, but it is a bit hard to understand the purpose of this option.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org