[GitHub] [activemq-artemis] AntonRoskvist commented on a diff in pull request #4382: ARTEMIS-4184 Bidges with concurrency not cleared properly on config r…

["AntonRoskvist (via GitHub)" <gi...@apache.org>]

AntonRoskvist commented on code in PR #4382:
URL: https://github.com/apache/activemq-artemis/pull/4382#discussion_r1230794849


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4586,9 +4586,12 @@ private void deployReloadableConfigFromConfiguration() throws Exception {
          for (BridgeConfiguration newBridgeConfig : configuration.getBridgeConfigurations()) {
             newBridgeConfig.setParentName(newBridgeConfig.getName());
             Bridge existingBridge = clusterManager.getBridges().get(newBridgeConfig.getParentName());
+            if (existingBridge == null) {
+               existingBridge = clusterManager.getBridges().get(newBridgeConfig.getParentName() + "-0");

Review Comment:
   @clebertsuconic 
   I agree, that really wasn't nice. I was using the concatenation there because concurrent bridges get named uniquely to be manageable by appending -0, -1 and so on to their name. At this point that has yet to happen to the newBridge.
   
   I made some changes here and also rebased against main, hope it's looking better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org