You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/19 15:19:31 UTC

[GitHub] [pulsar] zhaorongsheng opened a new pull request #6769: change nondurable cursor to active

zhaorongsheng opened a new pull request #6769: change nondurable cursor to active
URL: https://github.com/apache/pulsar/pull/6769
 
 
   
   ### Motivation
   
   When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance.
   
   ### Modifications
   
   Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()`
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   *ManagedCursorTest.testNonDurableCursorActive()*
     - add test to check `NonDurableCursorImpl` activity
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services