You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Brian W. Fitzpatrick" <fi...@collab.net> on 2005/02/24 21:36:02 UTC
[Locking] Proposal to change ra_lock and ra_unlock to take lists
of lock tokens
The Issue At Hand:
With the current locking design, my only recourse in a situation where
we need to unlock (or lock) multiple files is to pass each lock token
that we discover to svn_ra_unlock (or svn_ra_lock) and send each
lock/unlock request over the ra layer one at a time. While simple
enough, this is extremely inefficient.
The Proposed Solution:
After discussing this with sussman and cmpilato, I propose that we
modify svn_ra_lock and svn_ra_unlock to take a list of lock tokens.
That way, each ra layer can deal with the tokens as efficiently or
inefficiently as necessary. Sussman's already got some ideas WRT ra_dav
using POST requests instead of LOCK and UNLOCK requests, and the other
layers can just shoot the whole list at the server in one request.
Thoughts?
-Fitz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Locking] Proposal to change ra_lock and ra_unlock to take lists
of lock tokens
Posted by Branko Čibej <br...@xbc.nu>.
Brian W. Fitzpatrick wrote:
>The Issue At Hand:
>
>With the current locking design, my only recourse in a situation where
>we need to unlock (or lock) multiple files is to pass each lock token
>that we discover to svn_ra_unlock (or svn_ra_lock) and send each
>lock/unlock request over the ra layer one at a time. While simple
>enough, this is extremely inefficient.
>
>The Proposed Solution:
>
>After discussing this with sussman and cmpilato, I propose that we
>modify svn_ra_lock and svn_ra_unlock to take a list of lock tokens.
>That way, each ra layer can deal with the tokens as efficiently or
>inefficiently as necessary. Sussman's already got some ideas WRT ra_dav
>using POST requests instead of LOCK and UNLOCK requests, and the other
>layers can just shoot the whole list at the server in one request.
>
>Thoughts?
>
>
+1 all over that, I thought we already agreed to do that? Or is it just
svn_fs_lock_list without an RA equivalent?
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Locking] Proposal to change ra_lock and ra_unlock to take lists of lock tokens
Posted by "Brian W. Fitzpatrick" <fi...@collab.net>.
On Feb 25, 2005, at 1:59 AM, Peter N. Lundblad wrote:
> On Thu, 24 Feb 2005, Brian W. Fitzpatrick wrote:
>
>> The Proposed Solution:
>>
>> After discussing this with sussman and cmpilato, I propose that we
>> modify svn_ra_lock and svn_ra_unlock to take a list of lock tokens.
>> That way, each ra layer can deal with the tokens as efficiently or
>> inefficiently as necessary. Sussman's already got some ideas WRT
>> ra_dav
>> using POST requests instead of LOCK and UNLOCK requests, and the other
>> layers can just shoot the whole list at the server in one request.
>>
> +1
>
> We may want to consider doing the same for svn_client_{,un}lock as
> well.
> (The reason for not doing this in the first place was consistency with
> other svn_client_* functions.)>
I'll add this to the list. Thanks.
-Fitz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Locking] Proposal to change ra_lock and ra_unlock to take lists of lock tokens
Posted by Ben Collins-Sussman <su...@collab.net>.
On Feb 25, 2005, at 1:59 AM, Peter N. Lundblad wrote:
> On Thu, 24 Feb 2005, Brian W. Fitzpatrick wrote:
>
>> The Proposed Solution:
>>
>> After discussing this with sussman and cmpilato, I propose that we
>> modify svn_ra_lock and svn_ra_unlock to take a list of lock tokens.
>> That way, each ra layer can deal with the tokens as efficiently or
>> inefficiently as necessary. Sussman's already got some ideas WRT
>> ra_dav
>> using POST requests instead of LOCK and UNLOCK requests, and the other
>> layers can just shoot the whole list at the server in one request.
>>
> +1
>
> We may want to consider doing the same for svn_client_{,un}lock as
> well.
> (The reason for not doing this in the first place was consistency with
> other svn_client_* functions.)>
>
Oh yeah, definitely. The svn_client_ funcs need to take a list too.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Locking] Proposal to change ra_lock and ra_unlock to take lists
of lock tokens
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Thu, 24 Feb 2005, Brian W. Fitzpatrick wrote:
> The Proposed Solution:
>
> After discussing this with sussman and cmpilato, I propose that we
> modify svn_ra_lock and svn_ra_unlock to take a list of lock tokens.
> That way, each ra layer can deal with the tokens as efficiently or
> inefficiently as necessary. Sussman's already got some ideas WRT ra_dav
> using POST requests instead of LOCK and UNLOCK requests, and the other
> layers can just shoot the whole list at the server in one request.
>
+1
We may want to consider doing the same for svn_client_{,un}lock as well.
(The reason for not doing this in the first place was consistency with
other svn_client_* functions.)>
Regards,
//Peter
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org