[GitHub] [spark] cloud-fan commented on pull request #42864: [WIP][SPARK-45112][SQL] Use UnresolvedFunction based resolution in SQL Dataset functions

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on PR #42864:
URL: https://github.com/apache/spark/pull/42864#issuecomment-1723688982

   To add more color to @peter-toth 's comment. Think about a base trait to define these function APIs
   ```
   trait SQLFunctionsBase {
     // api doc ...
     def substring(...) = fn("substring", ...)
     
     protected def fn(...)
   }
   
   ```
   Then in the spark connect side, we override `fn` to create proto message for SQL function, in Spark SQL, we override `fn` to  create `UnresolvedFunction`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org