[Bug 56470] New: AntUnits logcontent task returns a one line log string

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56470

            Bug ID: 56470
           Summary: AntUnits logcontent task returns a one line log string
           Product: Ant
           Version: unspecified
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: AntUnit
          Assignee: notifications@ant.apache.org
          Reporter: chris.holman@awltux.com

Created attachment 31569
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31569&action=edit
Patch file for LogCapturer.java

The logcontent task outputs the log on one single line.

Using the following in the AntUnit test:

<project> 
...
    <target name="tearDown">
        <echo>This line has no EOL character appended...</echo>
        <echo>So this is on the same line in the log file</echo>
        <!-- Write to logfile -->
        <concat destfile="${logfile}" fixlastline="yes">
            <au:logcontent/>
        </concat>        
    </target>
</project>

This can be easily fixed in: org.apache.ant.antunit.LogCapturer

There is a SVN patch attached that adds a LINE_SEPARATOR to the end of each log
entry in the LogCapturer.messageLogged method.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56470] AntUnits logcontent task returns a one line log string

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56470

Stefan Bodewig <bo...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.2
   Target Milestone|---                         |1.3
                 OS|                            |All

--- Comment #1 from Stefan Bodewig <bo...@apache.org> ---
changes similar to your patch have been committed as svn revision 1591972

I'd like to wait for the Gump run to determine whether an option to insert line
breaks is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56470] AntUnits logcontent task returns a one line log string

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56470

--- Comment #2 from Stefan Bodewig <bo...@apache.org> ---
One test inside Ant's own testsuite fails, this is because it tests the order
of two adjacent log messages - something you cannot do with separate
assertLogContains assertions. [1]

I'd add an attribute to assertLogContains and the logcontent resource -
mergeLines with default true? - and modify LogCapturer to provide logs with and
without merged lines.

[1] testRedirector14 in src/tests/antunit/taskdefs/exec/apply-test.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56470] AntUnits logcontent task returns a one line log string

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56470

Stefan Bodewig <bo...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Stefan Bodewig <bo...@apache.org> ---
added mergeLines in several places and retained backwards compatibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.