You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by James Carman <ja...@carmanconsulting.com> on 2008/02/19 17:14:49 UTC

[VOTE] Release Proxy 1.0

I have prepared a commons-proxy-1.0-rc1 release candidate.  The
distribution files can be found at:

http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/

and the site can be found at:

http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site

Note: This is my first release, so please look this over with a
fine-toothed comb.  I don't want to make any mistakes.  The only thing
I wasn't quite sure of was whether or not to actually include the
generated ant build files in my distribution.  Maven2 could generate
the ant build files just fine and my build isn't doing anything crazy.
 If I need to include them, let me know and I can cut rc2 with that in
there.  I believe I followed the rest of the instructions carefully.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
I'll include that in the rc2 email. ;)


On 2/19/08, sebb <se...@gmail.com> wrote:
> It would be helpful to include the SVN tag in the e-mail so the
> release artifacts can be checked against SVN...
>
> On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > distribution files can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> >
> > and the site can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> >
> > Note: This is my first release, so please look this over with a
> > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > I wasn't quite sure of was whether or not to actually include the
> > generated ant build files in my distribution.  Maven2 could generate
> > the ant build files just fine and my build isn't doing anything crazy.
> >  If I need to include them, let me know and I can cut rc2 with that in
> > there.  I believe I followed the rest of the instructions carefully.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
It would be helpful to include the SVN tag in the e-mail so the
release artifacts can be checked against SVN...

On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> distribution files can be found at:
>
> http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
>
> and the site can be found at:
>
> http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
>
> Note: This is my first release, so please look this over with a
> fine-toothed comb.  I don't want to make any mistakes.  The only thing
> I wasn't quite sure of was whether or not to actually include the
> generated ant build files in my distribution.  Maven2 could generate
> the ant build files just fine and my build isn't doing anything crazy.
>  If I need to include them, let me know and I can cut rc2 with that in
> there.  I believe I followed the rest of the instructions carefully.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, Niall Pemberton <ni...@gmail.com> wrote:
> On Feb 19, 2008 6:31 PM, sebb <se...@gmail.com> wrote:
> > On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > > On 2/19/08, sebb <se...@gmail.com> wrote:
> > > > On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > > > > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > > > > distribution files can be found at:
> > > > >
> > > > > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> > > > >
> > > >
> > > > Can't access the archives:
> > > >
> > > > You don't have permission to access
> > > > /~jcarman/commons-proxy-1.0-rc1/commons-proxy-1.0-rc1-bin.zip on this
> > > > server.
> > >
> > > Sorry.  I checked that the directory listing worked.  I just did a
> > > chmod a+rx * in that dir, so everything should be okay now.
> >
> > That's fixed it, thanks.
> >
> > There are no digests (.md5 or .sha) and no signature (.asc) files.
> >
> > The Manifest file in the binary jar is rather difficult to read - in
> > particular the import-export lines are not nicely wrapped. Also the
> > ordering of entries is rather odd, e.g. the compiler source and target
> > versions are normally next to each other.
>
> The manifest is being generated using the maven bundle plugin[1]  and
> those import/export lines are part of the OSGi info it adds to the
> manifest. While it might be nice if it didn't change the order of
> entries (I did suggest that[2]) or the line wrapping was easier on the
> eye AIUI the manifest is meant to be machine-read and the rules for
> its format (e.g. line length and wrapping) reflect that.
>
> The only thing I can suggest is raising an issue ticket with the felix
> project - but its probably not in the maven plugins control - since
> its just a wrapper for the BND tool[3]
>

Might do that.

> Niall
>
>
> [1] http://felix.apache.org/site/maven-bundle-plugin-bnd.html
> [2] https://issues.apache.org/jira/browse/FELIX-449?focusedCommentId=12557217#action_12557217

The issue has been closed; it looks as though your suggestion re the
non-OSGI manifest entries was overlooked.

> [3] http://www.aqute.biz/Code/Bnd
> > The NOTICE.txt file in SVN says:
> >
> > Copyright 2006-2008
> >
> > However the pom says:
> >
> > <inceptionYear>2005</inceptionYear>
> >
> > The code seems to build OK using maven and java 1.4.
> >
> > What version of Java is Proxy intended for?
> >
> > Currently it inherits the java source and target versions from the
> > parent POM; these are both set to 1.3.
> >
> >
> >
> > > >
> > > > > and the site can be found at:
> > > > >
> > > > > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> > > > >
> > > > > Note: This is my first release, so please look this over with a
> > > > > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > > > > I wasn't quite sure of was whether or not to actually include the
> > > > > generated ant build files in my distribution.  Maven2 could generate
> > > > > the ant build files just fine and my build isn't doing anything crazy.
> > > > >  If I need to include them, let me know and I can cut rc2 with that in
> > > > > there.  I believe I followed the rest of the instructions carefully.
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > >
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by Niall Pemberton <ni...@gmail.com>.
On Feb 19, 2008 6:31 PM, sebb <se...@gmail.com> wrote:
> On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > On 2/19/08, sebb <se...@gmail.com> wrote:
> > > On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > > > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > > > distribution files can be found at:
> > > >
> > > > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> > > >
> > >
> > > Can't access the archives:
> > >
> > > You don't have permission to access
> > > /~jcarman/commons-proxy-1.0-rc1/commons-proxy-1.0-rc1-bin.zip on this
> > > server.
> >
> > Sorry.  I checked that the directory listing worked.  I just did a
> > chmod a+rx * in that dir, so everything should be okay now.
>
> That's fixed it, thanks.
>
> There are no digests (.md5 or .sha) and no signature (.asc) files.
>
> The Manifest file in the binary jar is rather difficult to read - in
> particular the import-export lines are not nicely wrapped. Also the
> ordering of entries is rather odd, e.g. the compiler source and target
> versions are normally next to each other.

The manifest is being generated using the maven bundle plugin[1]  and
those import/export lines are part of the OSGi info it adds to the
manifest. While it might be nice if it didn't change the order of
entries (I did suggest that[2]) or the line wrapping was easier on the
eye AIUI the manifest is meant to be machine-read and the rules for
its format (e.g. line length and wrapping) reflect that.

The only thing I can suggest is raising an issue ticket with the felix
project - but its probably not in the maven plugins control - since
its just a wrapper for the BND tool[3]

Niall


[1] http://felix.apache.org/site/maven-bundle-plugin-bnd.html
[2] https://issues.apache.org/jira/browse/FELIX-449?focusedCommentId=12557217#action_12557217
[3] http://www.aqute.biz/Code/Bnd

> The NOTICE.txt file in SVN says:
>
> Copyright 2006-2008
>
> However the pom says:
>
> <inceptionYear>2005</inceptionYear>
>
> The code seems to build OK using maven and java 1.4.
>
> What version of Java is Proxy intended for?
>
> Currently it inherits the java source and target versions from the
> parent POM; these are both set to 1.3.
>
>
>
> > >
> > > > and the site can be found at:
> > > >
> > > > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> > > >
> > > > Note: This is my first release, so please look this over with a
> > > > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > > > I wasn't quite sure of was whether or not to actually include the
> > > > generated ant build files in my distribution.  Maven2 could generate
> > > > the ant build files just fine and my build isn't doing anything crazy.
> > > >  If I need to include them, let me know and I can cut rc2 with that in
> > > > there.  I believe I followed the rest of the instructions carefully.
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> On 2/19/08, sebb <se...@gmail.com> wrote:
> > > It's written to be 1.3 compliant.
> >
> > It appears to be so if one uses Maven, however I just tried it with
> > Eclipse, and there are some classes which are not compatible with 1.3.
> >
> > RuntimeException does not have RuntimeException([String,]Throwable)
> > constructors, nor  do Exception.getCause() String.matche(String) exist
> > in 1.3.
>
> Okay, so how about we say it's 1.4 compliant?  It's a brand new
> library, so there really are no existing users.  The ones I have are
> already using it based on what's in SVN, so they're probably okay with
> the 1.4edness (it's a word, I promise).  Should I update the POM to
> override what we have in the parent?

Your choice - you could either rework to make it compliant with 1.3,
or update the POM to 1.4.

> This brings up an interesting
> question, though.  Why isn't this flagged?  I said it's supposed to be
> 1.3 compliant to maven.  Shouldn't the maven build fail if I've got
> stuff in there that's not 1.3 compliant?
>

The compiler version flags don't affect the run-time library that is used.
I don't know if there are plans to fix this.

The build would fail if the source used a newer syntax (such as
generics), but otherwise it does nothing as far as I know. The target
version just affects the class version.

See this comment from Simon Kitching:

https://issues.apache.org/jira/browse/MATH-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557925#action_12557925

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by Dennis Lundberg <de...@apache.org>.
sebb wrote:
> On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
>> On 2/19/08, sebb <se...@gmail.com> wrote:
>>> On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
>>>> So, as far as I can tell these are the current issues with this
>>>> release candidate (and what I've done to fix them):
>>>>
>>>> 1.  Source Incompatible w/1.3 - Changed the source/target to 1.4 in
>>>> proxy's pom file
>>>>
>>>> 2.  Javadoc Links - The new Javadocs will have links to JDK, XML-RPC,
>>>> Javassist, AOP Alliance, and the "concurrent" stuff from Doug Lea's
>>>> library.
>>>>
>>>> 3.  Digests/Signatures - Release candidate 2 distributions will have
>>>> associated digest and signature files.
>>>>
>>>> 4.  Notice file copyright year range doesn't match the "inceptionYear"
>>>> property in the pom file - I change the Notice file to match.
>>>>
>>>> 5.  Manifest file sloppiness: The felix plugin is causing this.
>>>>
>>>> So, am I ready for an rc2 for you guys?
>>>>
>>> It would be useful to document the minimum Java version on the
>>> web-site main page.
>>>
>>> Some Commons projects have developer pages; might be worth considering
>>> this for a future release, if not now.
>> Do you know of any commons projects that currently list their minimum
>> Java version?  I'd like to borrow from what they've done.  Or, is
>> there a preferred place that we should put something like that?
> 
> Here a good example:
> 
> http://commons.apache.org/configuration/dependencies.html
> 
>>  It would be nice if the dependencies page listed the source/target Java
>> versions that were used by the compiler.
>>
> 
> Indeed, I tried suggesting that ...

Niall has filed a feature request for this:

   http://jira.codehaus.org/browse/MPIR-80

> 
>> I might just wait until the next release for a "developer" page.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> On 2/19/08, sebb <se...@gmail.com> wrote:
> > On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > > So, as far as I can tell these are the current issues with this
> > > release candidate (and what I've done to fix them):
> > >
> > > 1.  Source Incompatible w/1.3 - Changed the source/target to 1.4 in
> > > proxy's pom file
> > >
> > > 2.  Javadoc Links - The new Javadocs will have links to JDK, XML-RPC,
> > > Javassist, AOP Alliance, and the "concurrent" stuff from Doug Lea's
> > > library.
> > >
> > > 3.  Digests/Signatures - Release candidate 2 distributions will have
> > > associated digest and signature files.
> > >
> > > 4.  Notice file copyright year range doesn't match the "inceptionYear"
> > > property in the pom file - I change the Notice file to match.
> > >
> > > 5.  Manifest file sloppiness: The felix plugin is causing this.
> > >
> > > So, am I ready for an rc2 for you guys?
> > >
> >
> > It would be useful to document the minimum Java version on the
> > web-site main page.
> >
> > Some Commons projects have developer pages; might be worth considering
> > this for a future release, if not now.
>
> Do you know of any commons projects that currently list their minimum
> Java version?  I'd like to borrow from what they've done.  Or, is
> there a preferred place that we should put something like that?

Here a good example:

http://commons.apache.org/configuration/dependencies.html

>  It would be nice if the dependencies page listed the source/target Java
> versions that were used by the compiler.
>

Indeed, I tried suggesting that ...

> I might just wait until the next release for a "developer" page.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
On 2/19/08, James Carman <ja...@carmanconsulting.com> wrote:
> On 2/19/08, sebb <se...@gmail.com> wrote:
> > On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > > So, as far as I can tell these are the current issues with this
> > > release candidate (and what I've done to fix them):
> > >
> > > 1.  Source Incompatible w/1.3 - Changed the source/target to 1.4 in
> > > proxy's pom file
> > >
> > > 2.  Javadoc Links - The new Javadocs will have links to JDK, XML-RPC,
> > > Javassist, AOP Alliance, and the "concurrent" stuff from Doug Lea's
> > > library.
> > >
> > > 3.  Digests/Signatures - Release candidate 2 distributions will have
> > > associated digest and signature files.
> > >
> > > 4.  Notice file copyright year range doesn't match the "inceptionYear"
> > > property in the pom file - I change the Notice file to match.
> > >
> > > 5.  Manifest file sloppiness: The felix plugin is causing this.
> > >
> > > So, am I ready for an rc2 for you guys?
> > >
> >
> > It would be useful to document the minimum Java version on the
> > web-site main page.
> >
> > Some Commons projects have developer pages; might be worth considering
> > this for a future release, if not now.
>
> Do you know of any commons projects that currently list their minimum
> Java version?  I'd like to borrow from what they've done.  Or, is
> there a preferred place that we should put something like that?  It
> would be nice if the dependencies page listed the source/target Java
> versions that were used by the compiler.

Nevermind, I added the following to the "Releases" section:

"Note: The 1.x releases are compatible with JDK1.4+."

So, I think I'm going to go ahead and cut the release candidate 2.

>
> I might just wait until the next release for a "developer" page.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
On 2/19/08, sebb <se...@gmail.com> wrote:
> On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > So, as far as I can tell these are the current issues with this
> > release candidate (and what I've done to fix them):
> >
> > 1.  Source Incompatible w/1.3 - Changed the source/target to 1.4 in
> > proxy's pom file
> >
> > 2.  Javadoc Links - The new Javadocs will have links to JDK, XML-RPC,
> > Javassist, AOP Alliance, and the "concurrent" stuff from Doug Lea's
> > library.
> >
> > 3.  Digests/Signatures - Release candidate 2 distributions will have
> > associated digest and signature files.
> >
> > 4.  Notice file copyright year range doesn't match the "inceptionYear"
> > property in the pom file - I change the Notice file to match.
> >
> > 5.  Manifest file sloppiness: The felix plugin is causing this.
> >
> > So, am I ready for an rc2 for you guys?
> >
>
> It would be useful to document the minimum Java version on the
> web-site main page.
>
> Some Commons projects have developer pages; might be worth considering
> this for a future release, if not now.

Do you know of any commons projects that currently list their minimum
Java version?  I'd like to borrow from what they've done.  Or, is
there a preferred place that we should put something like that?  It
would be nice if the dependencies page listed the source/target Java
versions that were used by the compiler.

I might just wait until the next release for a "developer" page.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> So, as far as I can tell these are the current issues with this
> release candidate (and what I've done to fix them):
>
> 1.  Source Incompatible w/1.3 - Changed the source/target to 1.4 in
> proxy's pom file
>
> 2.  Javadoc Links - The new Javadocs will have links to JDK, XML-RPC,
> Javassist, AOP Alliance, and the "concurrent" stuff from Doug Lea's
> library.
>
> 3.  Digests/Signatures - Release candidate 2 distributions will have
> associated digest and signature files.
>
> 4.  Notice file copyright year range doesn't match the "inceptionYear"
> property in the pom file - I change the Notice file to match.
>
> 5.  Manifest file sloppiness: The felix plugin is causing this.
>
> So, am I ready for an rc2 for you guys?
>

It would be useful to document the minimum Java version on the
web-site main page.

Some Commons projects have developer pages; might be worth considering
this for a future release, if not now.

> On 2/19/08, James Carman <ja...@carmanconsulting.com> wrote:
> > On 2/19/08, sebb <se...@gmail.com> wrote:
> > > > It's written to be 1.3 compliant.
> > >
> > > It appears to be so if one uses Maven, however I just tried it with
> > > Eclipse, and there are some classes which are not compatible with 1.3.
> > >
> > > RuntimeException does not have RuntimeException([String,]Throwable)
> > > constructors, nor  do Exception.getCause() String.matche(String) exist
> > > in 1.3.
> >
> > Okay, so how about we say it's 1.4 compliant?  It's a brand new
> > library, so there really are no existing users.  The ones I have are
> > already using it based on what's in SVN, so they're probably okay with
> > the 1.4edness (it's a word, I promise).  Should I update the POM to
> > override what we have in the parent?  This brings up an interesting
> > question, though.  Why isn't this flagged?  I said it's supposed to be
> > 1.3 compliant to maven.  Shouldn't the maven build fail if I've got
> > stuff in there that's not 1.3 compliant?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
So, as far as I can tell these are the current issues with this
release candidate (and what I've done to fix them):

1.  Source Incompatible w/1.3 - Changed the source/target to 1.4 in
proxy's pom file

2.  Javadoc Links - The new Javadocs will have links to JDK, XML-RPC,
Javassist, AOP Alliance, and the "concurrent" stuff from Doug Lea's
library.

3.  Digests/Signatures - Release candidate 2 distributions will have
associated digest and signature files.

4.  Notice file copyright year range doesn't match the "inceptionYear"
property in the pom file - I change the Notice file to match.

5.  Manifest file sloppiness: The felix plugin is causing this.

So, am I ready for an rc2 for you guys?

On 2/19/08, James Carman <ja...@carmanconsulting.com> wrote:
> On 2/19/08, sebb <se...@gmail.com> wrote:
> > > It's written to be 1.3 compliant.
> >
> > It appears to be so if one uses Maven, however I just tried it with
> > Eclipse, and there are some classes which are not compatible with 1.3.
> >
> > RuntimeException does not have RuntimeException([String,]Throwable)
> > constructors, nor  do Exception.getCause() String.matche(String) exist
> > in 1.3.
>
> Okay, so how about we say it's 1.4 compliant?  It's a brand new
> library, so there really are no existing users.  The ones I have are
> already using it based on what's in SVN, so they're probably okay with
> the 1.4edness (it's a word, I promise).  Should I update the POM to
> override what we have in the parent?  This brings up an interesting
> question, though.  Why isn't this flagged?  I said it's supposed to be
> 1.3 compliant to maven.  Shouldn't the maven build fail if I've got
> stuff in there that's not 1.3 compliant?
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
On 2/19/08, sebb <se...@gmail.com> wrote:
> > It's written to be 1.3 compliant.
>
> It appears to be so if one uses Maven, however I just tried it with
> Eclipse, and there are some classes which are not compatible with 1.3.
>
> RuntimeException does not have RuntimeException([String,]Throwable)
> constructors, nor  do Exception.getCause() String.matche(String) exist
> in 1.3.

Okay, so how about we say it's 1.4 compliant?  It's a brand new
library, so there really are no existing users.  The ones I have are
already using it based on what's in SVN, so they're probably okay with
the 1.4edness (it's a word, I promise).  Should I update the POM to
override what we have in the parent?  This brings up an interesting
question, though.  Why isn't this flagged?  I said it's supposed to be
1.3 compliant to maven.  Shouldn't the maven build fail if I've got
stuff in there that's not 1.3 compliant?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> On 2/19/08, sebb <se...@gmail.com> wrote:
> >
> > There are no digests (.md5 or .sha) and no signature (.asc) files.
> >
>
> I went by these directions:
>
> http://commons.apache.org/releases/prepare.html
>
> which doesn't mention anything about doing digests or signing the
> release candidates.  That is left for the next step of actually
> publishing the release.  However, I think I should sign the rc2 so
> that you guys can look over that to make sure I do that correctly
> also.
>

OK - most other votes I've seen also include them.

> > The Manifest file in the binary jar is rather difficult to read - in
> > particular the import-export lines are not nicely wrapped. Also the
> > ordering of entries is rather odd, e.g. the compiler source and target
> > versions are normally next to each other.
> >
>
> See Niall's answer regarding the manifest.
>

OK.

> > The NOTICE.txt file in SVN says:
> >
> > Copyright 2006-2008
> >
> > However the pom says:
> >
> > <inceptionYear>2005</inceptionYear>
>
> I probably should change the NOTICE.txt file to 2005 - 2008.
>
> >
> > The code seems to build OK using maven and java 1.4.
> >
> > What version of Java is Proxy intended for?
> >
> > Currently it inherits the java source and target versions from the
> > parent POM; these are both set to 1.3.
> >
> >
>
> It's written to be 1.3 compliant.

It appears to be so if one uses Maven, however I just tried it with
Eclipse, and there are some classes which are not compatible with 1.3.

RuntimeException does not have RuntimeException([String,]Throwable)
constructors, nor  do Exception.getCause() String.matche(String) exist
in 1.3.

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
On 2/19/08, sebb <se...@gmail.com> wrote:
>
> There are no digests (.md5 or .sha) and no signature (.asc) files.
>

I went by these directions:

http://commons.apache.org/releases/prepare.html

which doesn't mention anything about doing digests or signing the
release candidates.  That is left for the next step of actually
publishing the release.  However, I think I should sign the rc2 so
that you guys can look over that to make sure I do that correctly
also.

> The Manifest file in the binary jar is rather difficult to read - in
> particular the import-export lines are not nicely wrapped. Also the
> ordering of entries is rather odd, e.g. the compiler source and target
> versions are normally next to each other.
>

See Niall's answer regarding the manifest.

> The NOTICE.txt file in SVN says:
>
> Copyright 2006-2008
>
> However the pom says:
>
> <inceptionYear>2005</inceptionYear>

I probably should change the NOTICE.txt file to 2005 - 2008.

>
> The code seems to build OK using maven and java 1.4.
>
> What version of Java is Proxy intended for?
>
> Currently it inherits the java source and target versions from the
> parent POM; these are both set to 1.3.
>
>

It's written to be 1.3 compliant.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> On 2/19/08, sebb <se...@gmail.com> wrote:
> > On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > > distribution files can be found at:
> > >
> > > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> > >
> >
> > Can't access the archives:
> >
> > You don't have permission to access
> > /~jcarman/commons-proxy-1.0-rc1/commons-proxy-1.0-rc1-bin.zip on this
> > server.
>
> Sorry.  I checked that the directory listing worked.  I just did a
> chmod a+rx * in that dir, so everything should be okay now.

That's fixed it, thanks.

There are no digests (.md5 or .sha) and no signature (.asc) files.

The Manifest file in the binary jar is rather difficult to read - in
particular the import-export lines are not nicely wrapped. Also the
ordering of entries is rather odd, e.g. the compiler source and target
versions are normally next to each other.

The NOTICE.txt file in SVN says:

Copyright 2006-2008

However the pom says:

<inceptionYear>2005</inceptionYear>

The code seems to build OK using maven and java 1.4.

What version of Java is Proxy intended for?

Currently it inherits the java source and target versions from the
parent POM; these are both set to 1.3.


> >
> > > and the site can be found at:
> > >
> > > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> > >
> > > Note: This is my first release, so please look this over with a
> > > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > > I wasn't quite sure of was whether or not to actually include the
> > > generated ant build files in my distribution.  Maven2 could generate
> > > the ant build files just fine and my build isn't doing anything crazy.
> > >  If I need to include them, let me know and I can cut rc2 with that in
> > > there.  I believe I followed the rest of the instructions carefully.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
On 2/19/08, sebb <se...@gmail.com> wrote:
> On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > distribution files can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> >
>
> Can't access the archives:
>
> You don't have permission to access
> /~jcarman/commons-proxy-1.0-rc1/commons-proxy-1.0-rc1-bin.zip on this
> server.

Sorry.  I checked that the directory listing worked.  I just did a
chmod a+rx * in that dir, so everything should be okay now.
>
> > and the site can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> >
> > Note: This is my first release, so please look this over with a
> > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > I wasn't quite sure of was whether or not to actually include the
> > generated ant build files in my distribution.  Maven2 could generate
> > the ant build files just fine and my build isn't doing anything crazy.
> >  If I need to include them, let me know and I can cut rc2 with that in
> > there.  I believe I followed the rest of the instructions carefully.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by sebb <se...@gmail.com>.
On 19/02/2008, James Carman <ja...@carmanconsulting.com> wrote:
> I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> distribution files can be found at:
>
> http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
>

Can't access the archives:

You don't have permission to access
/~jcarman/commons-proxy-1.0-rc1/commons-proxy-1.0-rc1-bin.zip on this
server.

> and the site can be found at:
>
> http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
>
> Note: This is my first release, so please look this over with a
> fine-toothed comb.  I don't want to make any mistakes.  The only thing
> I wasn't quite sure of was whether or not to actually include the
> generated ant build files in my distribution.  Maven2 could generate
> the ant build files just fine and my build isn't doing anything crazy.
>  If I need to include them, let me know and I can cut rc2 with that in
> there.  I believe I followed the rest of the instructions carefully.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
I wonder why that's not part of the parent pom?  That is a good idea! :)

On 2/19/08, Emmanuel Bourg <eb...@apache.org> wrote:
> A minor suggestion regarding the javadoc, that would be nice if the
> pages were linked to the JDK javadoc. This was done through the
> maven.javadoc.links property with Maven 1, I don't know the equivalent
> with Maven 2.
>
> Emmanuel Bourg
>
>
> James Carman a écrit :
> > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > distribution files can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> >
> > and the site can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> >
> > Note: This is my first release, so please look this over with a
> > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > I wasn't quite sure of was whether or not to actually include the
> > generated ant build files in my distribution.  Maven2 could generate
> > the ant build files just fine and my build isn't doing anything crazy.
> >  If I need to include them, let me know and I can cut rc2 with that in
> > there.  I believe I followed the rest of the instructions carefully.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by James Carman <ja...@carmanconsulting.com>.
Emmanuel,

I've added it into my pom.xml and I will include that in the rc2
release candidate.

On 2/19/08, Emmanuel Bourg <eb...@apache.org> wrote:
> A minor suggestion regarding the javadoc, that would be nice if the
> pages were linked to the JDK javadoc. This was done through the
> maven.javadoc.links property with Maven 1, I don't know the equivalent
> with Maven 2.
>
> Emmanuel Bourg
>
>
> James Carman a écrit :
> > I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> > distribution files can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> >
> > and the site can be found at:
> >
> > http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> >
> > Note: This is my first release, so please look this over with a
> > fine-toothed comb.  I don't want to make any mistakes.  The only thing
> > I wasn't quite sure of was whether or not to actually include the
> > generated ant build files in my distribution.  Maven2 could generate
> > the ant build files just fine and my build isn't doing anything crazy.
> >  If I need to include them, let me know and I can cut rc2 with that in
> > there.  I believe I followed the rest of the instructions carefully.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Proxy 1.0

Posted by Emmanuel Bourg <eb...@apache.org>.
A minor suggestion regarding the javadoc, that would be nice if the 
pages were linked to the JDK javadoc. This was done through the 
maven.javadoc.links property with Maven 1, I don't know the equivalent 
with Maven 2.

Emmanuel Bourg


James Carman a écrit :
> I have prepared a commons-proxy-1.0-rc1 release candidate.  The
> distribution files can be found at:
> 
> http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/
> 
> and the site can be found at:
> 
> http://people.apache.org/~jcarman/commons-proxy-1.0-rc1/site
> 
> Note: This is my first release, so please look this over with a
> fine-toothed comb.  I don't want to make any mistakes.  The only thing
> I wasn't quite sure of was whether or not to actually include the
> generated ant build files in my distribution.  Maven2 could generate
> the ant build files just fine and my build isn't doing anything crazy.
>  If I need to include them, let me know and I can cut rc2 with that in
> there.  I believe I followed the rest of the instructions carefully.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org