You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/23 20:37:20 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3602: risc-v/rv32im: Set MAXOPTIMIZATION regardless of any debug options

acassis commented on a change in pull request #3602:
URL: https://github.com/apache/incubator-nuttx/pull/3602#discussion_r619482960



##########
File path: arch/risc-v/src/rv32im/Toolchain.defs
##########
@@ -67,13 +69,6 @@ ifeq ($(CONFIG_RISCV_TOOLCHAIN),GNU_RVG)
   endif
 endif
 
-# Individual tools may limit the optimization level but, by default, the
-# optimization level will be set to -Os
-
-ifeq ($(CONFIG_DEBUG_SYMBOLS),)
-MAXOPTIMIZATION ?= -Os

Review comment:
       We need to understand in the first place why it was defined this way. I think @patacongo did this way to force small binaries size when DEBUG Symbols is not used. In the other hand when DEBUG Symbols is enabled  the "-Os" will mess with the GDB source file/line association.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org